Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #5234 (closed)

Opened 8 years ago

Closed 8 years ago

Bug: BfPixelBufferTest

Reported by: jburel Owned by: cblackburn
Priority: critical Milestone: OMERO-Beta4.3
Component: General Version: n.a.
Keywords: n.a. Cc: jamoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-06-02 (13)

Description

Review test, currently the 6 tests are not passing.

Change History (7)

comment:1 Changed 8 years ago by Colin Blackburn <C.Blackburn@…>

(In [bb108660bdb0a5b0ea5caec41fd835fc11f5fa74/ome.git] on branch develop) Fixed tests to get data dir from config. See #5234

comment:2 Changed 8 years ago by cblackburn

  • Cc jmoore added

This test uses the construct:

File srcFile = ResourceUtils.getFile("classpath:" + fileName);

the files used are in components/common/test/
This is as used in a couple of other tests. The test fails on local builds. Should this test be changed to create files rather than use these files?
The parallel python tests similarly use,

filename = self.OmeroPy / ".." / ".." / ".." / "components" / "common" / "test" / name

as used elsewhere in the integration tests. Again, should this be changed?

comment:3 Changed 8 years ago by jburel

  • Sprint changed from 2011-05-19 (12) to 2011-06-02 (13)

Moved from sprint 2011-05-19 (12)

comment:4 Changed 8 years ago by jmoore

Colin, it depends. In the case of ant-builds & resources, they should be copied to target/classes or target/test-classes, which would put them on the classpath. Can you give a specific example of a file that fails, and the invocation that causes it?

comment:5 Changed 8 years ago by cblackburn

The local use would be:

./build.py
./build.py test-compile
(start server)
./build.py -f components/tools/OmeroPy/build.xml test -DTEST=integration/BfPixelBufferTest

This fails locally but obviously works if I set the srcFile to an absolute path for the local files. For it to pass locally do I need to build differently?

comment:6 Changed 8 years ago by jmoore

What file is it looking for? Most likely, whatever it was didn't get properly added to the higher level *-test.jar See the "test.xml" file under any component. The test-compile target in the build.xml file of the component should add any needed resources to that jar.

comment:7 Changed 8 years ago by Colin Blackburn <C.Blackburn@…>

  • Remaining Time set to 0
  • Resolution set to fixed
  • Status changed from new to closed

(In [566a652f4b7e2aa4ff4d0b5d9e7d8581529abaed/ome.git] on branch develop) Updated build files to put test files in classpath for tests. Closes #5234

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.77357 sec.)

We're Hiring!