Task #5564 (closed)
Opened 8 years ago
Closed 8 years ago
Bug: toggling of "dataset as folder" options doesn't seem to work.
| Reported by: | jamoore | Owned by: | jburel |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-Beta4.3 |
| Component: | Insight | Version: | n.a. |
| Keywords: | n.a. | Cc: | saloynton |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2011-06-02 (13) |
Description
- Click on dataset (here "nifti" from #5442)
- Click on right arrow
- "Folder as dataset" is checked
- "New dataset from folder's name" is checkable. (see image "toggling-A")
From a conversation with Jean-Marie, I would think that "New dataset from folder's name" should always be grayed out when the object is a folder, and that the dropdown should only be active when the "Folder as dataset" is unclicked.
That is, unless the "New dataset from folder's name" works like the "Archive" toggle which sets or unsets all the others. (That might be useful.)
Another surprise is:
- click on "New dataset from folder's name"
- Add a single file
- "Folder as dataset" is set. Which makes sense if "New dataset from folder's name" is the default like the upper "Archive" check box
- but, uncheck the "New dataset from folder's name"
- Add a directory
- The "folder as dataset" is still clicked which feels odd.
Change History (6)
comment:1 Changed 8 years ago by jburel
comment:2 Changed 8 years ago by jburel
comment:3 Changed 8 years ago by jmoore
Jean-Marie: "The Location context (i.e. project/dataset) is taken into account before adding the file to the queue. So changing the context after you have added the file will have no effect on what's in the queue."
I'm not sure that's how it's working, but I like the idea. Should we think about making the rows completely immutable, and everything must be done via the Location context at the top?
But in general, I agree. It's more of a surprise than anything else. So an RFE is ok. People will probably be confused for this release, though.
comment:4 Changed 8 years ago by jburel
What can happen:
When you select a folder, and did not check "New dataset from folder's name"
by default the folder as Dataset check box is selected, when you tick the box, then the context before the folder was added is taken into account
comment:5 Changed 8 years ago by jburel
- Remaining Time set to 0.15
- Sprint set to 2011-06-02 (13)
- Status changed from new to accepted
- "Folder As Dataset" is now a value that can be configured in the config file, similar to archive or thumbnail. (Following Ola's comment). This might need to be moved to another location. Let's wait for local users feedback.
- The value will only be taken into account when a folder is selected and added to the queue. The Folder as dataset will have to impact if a file is selected. Confusing?? Same let's wait for feedback
- "New dataset from folder's name" is now selected if a file is selected and no dataset selected in drop-down (cf. other tickets)
- TODO: if folder selected, then "New dataset from folder's name" will be greyed out.
comment:6 Changed 8 years ago by jburel <j.burel@…>
- Remaining Time changed from 0.15 to 0
- Resolution set to fixed
- Status changed from accepted to closed
(In [053e8db46739009c66392e28d234b4e49df979c3/ome.git] on branch develop) Modify the behaviour of the various controls used to set
the datasets location. (close #5564)
My comments were not saved!!!
The workflow is as follow:
The Location context (i.e. project/dataset) is taken into account before adding the file to the queue. So changing the context after you have added the file will have no effect on what's in the queue.
If you want to change the context, you need to get the file back and add it again.
what we can do:
This become more a RFE than a bug. Another example where going through test scenarios on regular basis will be beneficial