Task #5594 (accepted)
Opened 13 years ago
Last modified 13 years ago
Bug: RawPixelsStore.close failure should fail the build. — at Version 2
Reported by: | jamoore | Owned by: | jmoore |
---|---|---|---|
Priority: | blocker | Milestone: | OMERO-Beta4.3 |
Component: | Services | Version: | n.a. |
Keywords: | n.a. | Cc: | cxallan, jburel, mlinkert |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | 2011-06-02 (13) |
Description (last modified by jmoore)
While testing #5556, this was logged on the server, causing an "invalid image" to be shown in Insight. Server-side this was logged:
2011-05-26 10:18:38,797 INFO [ loci.formats.in.MinimalTiffReader] (l.Server-8) Using JPEG 2000 resolution level 0 2011-05-26 10:18:38,812 ERROR [e.io.bioformats.OmeroPixelsPyramidWriter] (l.Server-8) Error during process processing! loci.formats.FormatException: Plane index:1 must be < 1 at loci.formats.FormatWriter.checkParams(FormatWriter.java:356) at loci.formats.out.TiffWriter.saveBytes(TiffWriter.java:153) at loci.formats.out.TiffWriter.saveBytes(TiffWriter.java:140) at ome.io.bioformats.OmeroPixelsPyramidWriter.recompressSeries(OmeroPixelsPyramidWriter.java:125) at ome.io.bioformats.OmeroPixelsPyramidWriter.postProcess(OmeroPixelsPyramidWriter.java:86) at ome.io.bioformats.OmeroPixelsPyramidWriter.close(OmeroPixelsPyramidWriter.java:52) at ome.io.bioformats.BfPyramidPixelBuffer.closeWriter(BfPyramidPixelBuffer.java:364) at ome.io.bioformats.BfPyramidPixelBuffer.close(BfPyramidPixelBuffer.java:611) at ome.services.RawPixelsBean.closePixelBuffer(RawPixelsBean.java:240) at ome.services.RawPixelsBean.clean(RawPixelsBean.java:225) at ome.services.RawPixelsBean.close(RawPixelsBean.java:217)
but no exception on RawPixelsStorePrx.close() reached the user since it is invoked via "closeQuietly". The logic needs to be changed so that if an exception is thrown the close happens quietly, but otherwise the close happens loudly.
Change History (2)
comment:1 Changed 13 years ago by jmoore
comment:2 Changed 13 years ago by jmoore
- Description modified (diff)
- Owner set to jmoore
- Sprint set to 2011-06-02 (13)
- Status changed from new to accepted
- Summary changed from Bug: Plane index :1 must be <1 to Bug: RawPixelsStore.close failure should fail the build.
Also occurs from the command line importer. See below. I think we need to handle the failed closing of the service as an import failure.