BUG: TestThumbs integration test failing

[wmoore]

Seems that these tests are failing because they expect a non-square thumbnail, but we always get a square thumbnail because the big test image is square?

E.g. when you ask for a thumbnail that is x: 64 y: 60 you get one that is 64 x 64. Shouldn't this give you a 60 x 60 thumbnail?

Tests can be fixed like this: you want me to commit this Josh?

make_test_single("getThumbnailByLongestSide", 64, 64, rint(64))
 make_test_single("getThumbnailDirect", 64, 64, rint(64), rint(64))
 make_test_single("getThumbnailForSectionDirect", 64, 64, 0, 0, rint(64), rint(64))
-make_test_single("getThumbnail", 64, 60, rint(64), rint(60))
+make_test_single("getThumbnail", 64, 64, rint(64), rint(60))
 make_test_single("getThumbnailByLongestSide", 60, 60, rint(60))
-make_test_single("getThumbnailDirect", 64, 60, rint(64), rint(60))
-make_test_single("getThumbnailForSectionDirect", 64, 60, 0, 0, rint(64), rint(60))
+make_test_single("getThumbnailDirect", 64, 64, rint(64), rint(60))
+make_test_single("getThumbnailForSectionDirect", 64, 64, 0, 0, rint(64), rint(60))
 make_test_set("getThumbnailSet", 64, 64, rint(64), rint(64))
 make_test_set("getThumbnailByLongestSideSet", 64, 64, rint(64))

======================================================================
FAIL [16.752s]: testGetThumbnailDirectx64x60 (integration.thumbs.TestThumbs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/test/integration/thumbs.py", line 97, in f
    self.assertTb(buf, x, y)
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/test/integration/thumbs.py", line 31, in assertTb
    self.assertEquals(unwrap(y), thumb.size[1])
AssertionError: 60 != 64
======================================================================
FAIL [16.752s]: testGetThumbnailForSectionDirectx0x0x64x60 (integration.thumbs.TestThumbs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/test/integration/thumbs.py", line 97, in f
    self.assertTb(buf, x, y)
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/test/integration/thumbs.py", line 31, in assertTb
    self.assertEquals(unwrap(y), thumb.size[1])
AssertionError: 60 != 64
======================================================================
FAIL [16.752s]: testGetThumbnailx64x60 (integration.thumbs.TestThumbs
)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/test/integration/thumbs.py", line 97, in f
    self.assertTb(buf, x, y)
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/test/integration/thumbs.py", line 31, in assertTb
    self.assertEquals(unwrap(y), thumb.size[1])
AssertionError: 60 != 64
----------------------------------------------------------------------

[jmoore]

Most important is to confirm with Chris what the API should be returning (and unify any documentation if its amiss). Otherwise, I'm fine with the changes.

[jburel]

Moved from sprint 2011-06-02 (13)

[Will Moore <will@…>]

(In [cd851722e91af56609f8e155dfc1f085592cfb66/ome.git] on branch develop) Fixing integration test thumbs.py to expect square thumbnails. Closes #5605