Task #5784 (closed)
Bug: testSeppuku failing
| Reported by: | wmoore | Owned by: | cneves |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-Beta4.3 |
| Component: | OmeroPy | Version: | n.a. |
| Keywords: | n.a. | Cc: | python-team@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2011-06-16 (14) |
Description (last modified by cneves)
Not sure how long this has been failing - probably less than a week.
wjm:OmeroPy will$ python test/gatewaytest/connection.py
..F.
======================================================================
FAIL: testSeppuku (__main__.ConnectionMethodsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "test/gatewaytest/connection.py", line 75, in testSeppuku
self.assertRaises(Ice.ConnectionLostException, self.getTestImage)
AssertionError: ConnectionLostException not raised
----------------------------------------------------------------------
Ran 4 tests in 50.509s
FAILED (failures=1)
Change History (3)
comment:1 Changed 8 years ago by cneves
- Description modified (diff)
- Remaining Time set to 0.1
- Status changed from new to accepted
comment:2 Changed 8 years ago by Carlos Neves <carlos@…>
- Remaining Time changed from 0.1 to 0
- Resolution set to fixed
- Status changed from accepted to closed
comment:3 Changed 8 years ago by Carlos Neves <carlos@…>
(In [b0b4b9922dea0e7f1bd74c04eb7291c6b40a0d6a/ome.git] on branch dev_4_1_custom) Fixing the reconnect on session lost abort path (fixes #5784).
What was happening in the failed test was that we had two connections on the same session uuid, and one requested the session to be killed. The theory is this should make the other connection die with a ConnectionLostException? on any request, but in practice at the last stage of the reconnection attempt instead of trying to rejoin the session uuid on a new connection, a completely new session was being created for the user if the credentials where available.
The code now prevents this scenario by making sure that the reconnection code can only attach to the previous session uuid or give up.
(In [45512d61ee4c81cd5fb62daf92aecaf0db5c0675/ome.git] on branch develop) Fixing the reconnect on session lost abort path (fixes #5784).
What was happening in the failed test was that we had two connections on the same session uuid, and one requested the session to be killed. The theory is this should make the other connection die with a ConnectionLostException? on any request, but in practice at the last stage of the reconnection attempt instead of trying to rejoin the session uuid on a new connection, a completely new session was being created for the user if the credentials where available.
The code now prevents this scenario by making sure that the reconnection code can only attach to the previous session uuid or give up.