Bug: error on closing tmp file

[jamoore]

11-06-06 11:10:58,548 INFO  [                ome.io.nio.PixelsService] (3-thread-1) SUCCESS -- Pyramid created for pixels id:6034
2011-06-06 11:10:58,548 INFO  [e.io.bioformats.OmeroPixelsPyramidWriter] (3-thread-1) close(/OMERO/Pixels/Dir-006/.6034_pyramid8316746933125247720.tmp)
2011-06-06 11:10:58,550 ERROR [                ome.io.nio.PixelsService] (3-thread-1) Error closing pixel pyramid.
java.io.FileNotFoundException: Source '/OMERO/Pixels/Dir-006/.6034_pyramid8316746933125247720.tmp' does not exist

Chris mentioned Colin might have seen such a race condition before. Any information would be useful. (Cause of #5786)

[cblackburn]

I've not seen this race condition, what I saw was a problem viewing jp2 files.


Scenario:

• Imported and viewed okay in Insight (closed Insight)
• Failed to view in webclient - spinning icon (closed webclient)
• Insight then gives: "image could not be opened" dialog.

Looking at the Pixels directory afterwards there was a lock and tmp files corresponding to the imported image.

[jmoore]

In discussions with Chris, it looks like the cause here is the closeWriter was throwing an exception because the BfPyramidPixelBuffer had been created in a write context despite the fact that the pyramid already existed. Further, when it through the exception, the lock was not released. closeWriter should always release the lock, and the "write" flag should only be respected if the pyramid file does not yet exist.

[jmoore <josh@…>]

(In [59afeac0142ea9204c44eed9ec2f8a170599d32f/ome.git] on branch develop) Fix ByPramidPixelBuffer ctor and closeWriter (Fix #5787)