Task #5808 (closed)
Opened 8 years ago
Closed 7 years ago
importer.config is not available to insight et al.
| Reported by: | jamoore | Owned by: | jburel |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-4.4.4 |
| Component: | Import | Version: | n.a. |
| Keywords: | n.a. | Cc: | cxallan, jburel, jamoore |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | n.a. |
Description
After the recent refactoring (#4835) the import.config file used by IniFileLoader inside of ImportConfig did not get refactored into the omero_client.jar with the rest of the classes.
This should probably be fixed, but it's unclear what repercussions it may have on insight.
Change History (9)
comment:1 Changed 8 years ago by jmoore
comment:2 Changed 8 years ago by jburel
No need to expose them. The code should actually be reviewed and cleaned up.
- most of the configuration available is already done externally in insight e.g. port, debug.
- Other sections are importer UI specific, so should probably be removed from that class e.g. history, quaqua
As discussed before, I think we should rethink that code (moved out of the importer package) instead of spending time making it available to other clients.
comment:3 Changed 8 years ago by jmoore
- Milestone changed from OMERO-Beta4.3 to OMERO-Beta4.3.1
Moving to 4.3.1 for handling
comment:4 Changed 8 years ago by jmoore
- Milestone changed from OMERO-Beta4.3.1 to Unscheduled
- Sprint 2011-07-07 (1) deleted
This may just introduce subtle bugs at this point, pushing. (My major concern is the creation of the temporary ini files, but that is apparently not causing any issues yet)
comment:5 Changed 8 years ago by jmoore
- Cc bwzloranger removed
- Owner jmoore deleted
- Summary changed from Bug: importer.config is not available to insight et al. to importer.config is not available to insight et al.
Adding to #2118 for something that may not be implemented.
comment:6 Changed 8 years ago by jburel
Referencing ticket #2118 has changed sprint.
comment:7 Changed 7 years ago by jburel
- Milestone changed from Unscheduled to OMERO-Beta4.4
- Owner set to jburel
Check flex format configuration. Move that to importer.xml.
comment:8 Changed 7 years ago by jburel
- Milestone changed from OMERO-4.4 to OMERO-4.4.1
comment:9 Changed 7 years ago by jburel
- Remaining Time changed from 0.1 to 0
- Resolution set to invalid
- Status changed from new to closed
J-M, thoughts?