Task #5983 (closed)
Opened 8 years ago
Closed 8 years ago
Bug: web does not check for version 4.3+
| Reported by: | jamoore | Owned by: | atarkowska |
|---|---|---|---|
| Priority: | critical | Milestone: | OMERO-Beta4.3.1 |
| Component: | Web | Version: | n.a. |
| Keywords: | n.a. | Cc: | wmoore, jburel, cneves |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2011-07-07 (1) |
Description
While testing #4910, it was found that it's possible to log in to a 4.2.2 server, but that one is immediately logged out on clicking, for example, "history". See the debug output attached which shows a NegativeSizeException which is not handled properly.
This is probably related the exception handling discussed in:
Attachments (1)
Change History (11)
Changed 8 years ago by jmoore
comment:1 Changed 8 years ago by atarkowska
- Remaining Time set to 0.2
comment:2 Changed 8 years ago by atarkowska
comment:3 Changed 8 years ago by atarkowska
- Owner changed from atarkowska to wmoore
comment:4 Changed 8 years ago by atarkowska
There is also a question which server version client should recognize as right one and which not. Should client 4.3.1 be able to connect to 4.3.x ?
comment:5 Changed 8 years ago by atarkowska
I tested omeroweb against 4.2.1 on mage and it does not allow to login and says Error: Client version does not match server, please contact administrator.
comment:6 Changed 8 years ago by jmoore
Ola, can you tell me how you tested that? I just used the latest code and logged in as root on mage with no warning.
comment:7 Changed 8 years ago by atarkowska
I run the latest web from trunk on my machine, specify the server Mage, use emdb credentials.
comment:8 Changed 8 years ago by jmoore
Ola, I just tried it again. It looks like the SSL flag is the difference.
comment:9 Changed 8 years ago by wmoore
- Owner changed from wmoore to atarkowska
comment:10 Changed 8 years ago by Aleksandra Tarkowska <A.Tarkowska@…>
- Remaining Time changed from 0.2 to 0
- Resolution set to fixed
- Status changed from new to closed
(In [1349c718c6076f68752ce7d170e3a4b9c0b40633/ome.git] on branch develop) this check the server version before establish connection, close #5983
That is not exactly true. Webclient checks server version when connection was not established in order to give feedback. Moving this out of testing connection is not enough complex solution. Becuase the main entry point for python clients is omero.gateway that should be checked on the connection level.