Bug: Failing test testBatchCopy

[wmoore]

Turning this test back on

wjm:OmeroPy will$ python test/gatewaytest/rdefs.py RDefsTest.testBatchCopy
E
======================================================================
ERROR: tests that we can copy rendering settings from one image to a set of targets
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/gatewaytest/rdefs.py", line 142, in testBatchCopy
    r = fakeRequest()
NameError: global name 'fakeRequest' is not defined

----------------------------------------------------------------------
Ran 1 test in 45.986s

FAILED (errors=1)

[Will Moore <will@…>]

(In [c3d42be8b475d171242220fbc64d74ac0655d385/ome.git] on branch develop) Turning back on gatewaytests. See #6037, #6038, #6039

[jburel]

Referencing ticket #4329 has changed sprint.

[jmoore]

Taking away from Carlos so someone else can pick up.

[cblackburn]

The method fakeRequest is not defined in or imported into this test module. However, it is defined in three other places. Tow of these implementations appear identical, the first listed below is different to the other two.

Macintosh-23:ome cblackburn$ git grep 'def fakeRequest'
components/tools/OmeroWeb/omeroweb/webadmin/tests/request_factory.py:def fakeRequest (method, path="/", params={}, **kwargs):
components/tools/OmeroWeb/omeroweb/webclient/tests/unittests.py:def fakeRequest (**kwargs):
components/tools/OmeroWeb/omeroweb/webgateway/tests/unittests.py:def fakeRequest (**kwargs):

There is a case to be made for some refactoring in the various web-related tests in OmeroWeb and OmeroPy.

However, running this test locally it fails before this point so needs further investigation.

======================================================================
ERROR: tests that we can copy rendering settings from one image to a set of targets
----------------------------------------------------------------------
Traceback (most recent call last):
  File "gatewaytest/rdefs.py", line 32, in setUp
    self.channels = self.image.getChannels()
  File "/Users/cblackburn/Work/repos/ome/dist/lib/python/omero/gateway/__init__.py", line 5095, in wrapped
    if not self._prepareRenderingEngine() \
  File "/Users/cblackburn/Work/repos/ome/dist/lib/python/omero/gateway/__init__.py", line 5287, in _prepareRenderingEngine
    self._re = self._prepareRE()
  File "/Users/cblackburn/Work/repos/ome/dist/lib/python/omero/gateway/__init__.py", line 5264, in _prepareRE
    re.resetDefaults()
  File "/Users/cblackburn/Work/repos/ome/dist/lib/python/omero/gateway/__init__.py", line 2956, in __call__
    return self.handle_exception(e, *args, **kwargs)
  File "/Users/cblackburn/Work/repos/ome/dist/lib/python/omero/gateway/__init__.py", line 2953, in __call__
    return self.f(*args, **kwargs)
  File "/Users/cblackburn/Work/repos/ome/dist/lib/python/omero_api_RenderingEngine_ice.py", line 409, in resetDefaults
    return _M_omero.api.RenderingEngine._op_resetDefaults.invoke(self, ((), _ctx))
ResourceError: exception ::omero::ResourceError
{
    serverStackTrace = ome.conditions.ResourceError: Pixels set is missing statistics for channel '0'. This suggests an image import error or failed image import.
...
    serverExceptionClass = ome.conditions.ResourceError
    message = Pixels set is missing statistics for channel '0'. This suggests an image import error or failed image import.
}

----------------------------------------------------------------------
Ran 1 test in 4.624s

FAILED (errors=1)

(Trimming stacktrace, see comment below.)

[Colin Blackburn <C.Blackburn@…>]

(In [fc6c47c9c6d403119126ae24599d95bc1eb96a10/ome.git] on branch develop) Re-disabling testBatchCopy, see #6038

[cblackburn]

The ResourceError? above was due to a broken db. Cleaning the db allowed the test to fail as described in the ticket. Pasting in a copy of the fakeRequest method along with necessary imports allowed test to progress further. However, the test then fails at the line

rv = simplejson.loads(views.copy_image_rdef_json(r, CLIENT_BASE, _conn=self.gateway)._get_content())

due to views not being imported. If views is imported there is then a simplejson error.

I think this test needs to be rewritten at some stage.