Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #6121 (closed)

Opened 8 years ago

Closed 8 years ago

Raw Pixels store improvement

Reported by: jburel Owned by: jburel
Priority: minor Milestone: OMERO-Beta4.3.2
Component: Services Version: n.a.
Keywords: n.a. Cc: cxallan, cblackburn, jburel
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-09-01 (4)

Description (last modified by jburel)

Add some matlab tests for getPlaneFromImageId
cf. e-mail on ome-users

Change History (22)

comment:1 Changed 8 years ago by jburel

  • Description modified (diff)

comment:2 Changed 8 years ago by jburel

  • Description modified (diff)
  • Remaining Time set to 0.5

comment:3 Changed 8 years ago by jburel

  • Status changed from new to accepted

comment:4 Changed 8 years ago by jburel

  • Milestone changed from OMERO-Beta4.3.1 to OMERO-Beta4.3.2
  • Sprint changed from 2011-07-07 (1) to 2011-07-21 (1)

comment:5 Changed 8 years ago by jburel

  • Cc cxallan cblackburn added

I was hoping to test getHypercube method in matlab to provide feedback to user but unfortunately the method is not implemented.
2 things:

  • The method needs to be available
  • then many tests missing inOmeroJava.test.integrationTest.RawPixelsStoreTest.

I now have the code ready in matlab.

Last edited 8 years ago by jburel (previous) (diff)

comment:6 Changed 8 years ago by jburel

  • Component changed from General to Services
  • Sprint 2011-07-21 (1) deleted
  • Summary changed from Matlab test to Raw Pixels store improvement

comment:7 Changed 8 years ago by jburel

  • Cc jburel added
  • Owner changed from jburel to cblackburn
  • Sprint set to 2011-07-21 (1)

comment:8 Changed 8 years ago by jburel

  • Owner cblackburn deleted
  • Status changed from accepted to new

comment:9 Changed 8 years ago by jburel

  • Owner set to cblackburn

comment:10 Changed 8 years ago by Colin Blackburn <C.Blackburn@…>

(In [16310e0d79d1833d589e77840b3091726917651d/ome.git] on branch develop) Implemented getHypercube in RawPixelsStore?. See #6121

comment:11 Changed 8 years ago by Colin Blackburn <C.Blackburn@…>

(In [15f893e551d84e59329221574af4bfb227d660eb/ome.git] on branch develop) Changed getCubeSize to getHypercubeSize for consistency with other get size methods. See #6121

comment:12 Changed 8 years ago by Colin Blackburn <C.Blackburn@…>

(In [6039c0cad42bd267f8c3178e1c800d80080c1a11/ome.git] on branch develop) Slight reorganisation as getHypercubeSize is no longer a private helper and it does bounds checking. See #6121

comment:13 Changed 8 years ago by Colin Blackburn <C.Blackburn@…>

(In [1d38d5ce1944fb906b4506c8bf0a5b7603e1689c/ome.git] on branch develop) Added a couple of tests to RawPixelsStoreTest? See #6121

comment:14 Changed 8 years ago by cblackburn

  • Owner changed from cblackburn to jburel

getHypercube is now implemented in the RawPIxelsStore. The current implementation uses plane-based gets so it may not be any more efficient. After testing from matlab we can look at the efficiency.

comment:15 Changed 8 years ago by Colin Blackburn <C.Blackburn@…>

(In [9c66478a6f17c0b09184c2a80b45e934945b2b40/ome.git] on branch develop) Implemented getHypercubeSize in InMemoryPlanarPixelBuffer?. See #6121

comment:16 Changed 8 years ago by Colin Blackburn <C.Blackburn@…>

(In [0910ab63383bf81c661f5d0fbddc5864af63e14e/ome.git] on branch develop) Implemented getHypercubeSize in TestPixelBuffer?. See #6121 Hopefully the last implementation!

comment:17 Changed 8 years ago by cxallan

  • Sprint changed from 2011-07-21 (1) to 2011-08-04 (2)

Moved from sprint 2011-07-21 (1)

comment:18 Changed 8 years ago by cxallan

  • Sprint 2011-08-04 (2) deleted

comment:19 Changed 8 years ago by jburel

  • Sprint set to 2011-08-18 (3)

Review tests in matlab now that getHypercube is implemented.

comment:20 Changed 8 years ago by jburel

Need to review when Colin comes back. Initial tests written, not passing due to some invalid check in implementation.

comment:21 Changed 8 years ago by jburel

  • Sprint changed from 2011-08-18 (3) to 2011-09-01 (4)

comment:22 Changed 8 years ago by jburel

  • Remaining Time changed from 0.5 to 0
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.82389 sec.)

We're Hiring!