Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #6317 (closed)

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

Remove 'guest' user from webadmin

Reported by: atarkowska Owned by: wmoore
Priority: critical Milestone: OMERO-Beta4.3.2
Component: WebAdmin Version: n.a.
Keywords: n.a. Cc: cxallan
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-08-04 (2)

Description

Having 'guest' user account on the experimenter list and allowing to manage this account cause problems.

Change History (9)

comment:1 Changed 13 years ago by atarkowska

  • Cc cxallan added
  • Remaining Time set to 1

comment:2 Changed 13 years ago by atarkowska

  • Status changed from new to accepted

comment:3 Changed 13 years ago by Aleksandra Tarkowska <atarkowska@…>

(In [a61219684315a9fb39cf7c96e348c16821e55165/ome.git] on branch develop) this prevent built-in users ('guest') and groups ('guest', 'user') from being edited, see #6317

comment:4 Changed 13 years ago by atarkowska

  • Owner changed from atarkowska to wmoore
  • Remaining Time changed from 1 to 0.5

Will, could you look into the gateway changes above and write test against getObjects("Experimenter") in order to test _ExperimenterWrapper._getQueryString.

Last edited 13 years ago by atarkowska (previous) (diff)

comment:5 Changed 13 years ago by Will Moore <will@…>

(In [a28d428d49cfd828a1020d3554c8d5f7288107a9/ome.git] on branch develop) Uncommenting gatewaytest lines for experimenter.copyGroupExpMap. Test fails. See #6317

comment:6 Changed 13 years ago by wmoore

Running test of getObject("Experimenter") before and after uncommenting lines that test loading of groupExperimenterMap. Test now fails

wjm:OmeroPy will$ python test/gatewaytest/get_objects.py GetObjectTest.testGetExperimenter
.
----------------------------------------------------------------------
Ran 1 test in 6.388s

OK
wjm:OmeroPy will$ python test/gatewaytest/get_objects.py GetObjectTest.testGetExperimenter
E
======================================================================
ERROR: testGetExperimenter (__main__.GetObjectTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/gatewaytest/get_objects.py", line 330, in testGetExperimenter
    for groupExpMap in exp.copyGroupExperimenterMap():
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/build/lib/omero_model_ExperimenterI.py", line 166, in copyGroupExperimenterMap
    if not self._groupExperimenterMapLoaded: self.throwNullCollectionException("groupExperimenterMapSeq")
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/build/lib/omero_model_ExperimenterI.py", line 53, in throwNullCollectionException
    "in order to update this collection.\n")
UnloadedEntityException: Error updating collection:groupExperimenterMapSeq
Collection is currently null. This can be seen
by testing "groupExperimenterMapSeqLoaded". This implies
that this collection was unloaded. Please refresh this object
in order to update this collection.


----------------------------------------------------------------------
Ran 1 test in 5.036s

FAILED (errors=1)
wjm:OmeroPy will$ 

comment:7 Changed 13 years ago by wmoore

Test is passing now - Checks that getObject("Experimenter") has groupExpMap loaded.

Do we want to remove methods from BlitzGateway?:

  • findExperimenter
  • listExperimenters
  • getExperimenter

we will need to leave findExperimenters(start="") since we cannot replace this functionality with getObjects()

comment:8 Changed 13 years ago by wmoore

  • Remaining Time changed from 0.5 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed

Remove Blitz 'Experimenter' methods is under another ticket #6394.

comment:9 Changed 13 years ago by Will Moore <will@…>

(In [f89a13c13aa1777ba237c4244e427e99fa9e17f3/ome.git] on branch develop) Updating comment in gatewaytest for getExperimenter. See #6317

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.68417 sec.)

We're Hiring!