Better error than EndpointParseException

[jamoore]

Currently OmeroPy et al through an EndpointParseException if no host is given:

In [1]: import omero

In [2]: c = omero.client()
---------------------------------------------------------------------------
EndpointParseException                    Traceback (most recent call last)

/Users/moore/GlencoeSoftware.git/git/omero.git/dist/<ipython console> in <module>()

/Users/moore/GlencoeSoftware.git/git/omero.git/dist/lib/python/omero/__init__.pyc in client(*args, **kwargs)
     26 def client(*args, **kwargs):
     27     import omero.clients
---> 28     return omero.clients.BaseClient(*args, **kwargs)
     29 
     30 class ClientError(exceptions.Exception):

/Users/moore/GlencoeSoftware.git/git/omero.git/dist/lib/python/omero/clients.py in __init__(self, args, id, host, port, pmap)
    126                 id.properties.setProperty(str(k), str(v))
    127 
--> 128         self._initData(id)
    129 
    130     def _repair(self, args, id, host, port, pmap):

/Users/moore/GlencoeSoftware.git/git/omero.git/dist/lib/python/omero/clients.py in _initData(self, id)
    229 
    230             try:
--> 231                 self.__ic = Ice.initialize(id)
    232             except Ice.EndpointParseException:
    233                 raise

/opt/Ice-3.3.1-64/python/Ice.py in initialize(args, data)
    338 #

    339 def initialize(args=None, data=None):
--> 340     communicator = IcePy.Communicator(args, data)
    341     return CommunicatorI(communicator)
    342 

EndpointParseException: exception ::Ice::EndpointParseException
{
    str = ssl  -p 4064 -h <"omero.host" not set>
}

Instead we could throw a omero.ClientError:

In [1]: import omero

In [2]: c = omero.client()
---------------------------------------------------------------------------
ClientError                               Traceback (most recent call last)

/Users/moore/GlencoeSoftware.git/git/omero.git/dist/<ipython console> in <module>()

/Users/moore/GlencoeSoftware.git/git/omero.git/dist/lib/python/omero/__init__.pyc in client(*args, **kwargs)
     26 def client(*args, **kwargs):
     27     import omero.clients
---> 28     return omero.clients.BaseClient(*args, **kwargs)
     29 
     30 class ClientError(exceptions.Exception):

/Users/moore/GlencoeSoftware.git/git/omero.git/dist/lib/python/omero/clients.py in __init__(self, args, id, host, port, pmap)
    126                 id.properties.setProperty(str(k), str(v))
    127 
--> 128         self._initData(id)
    129 
    130     def _repair(self, args, id, host, port, pmap):

/Users/moore/GlencoeSoftware.git/git/omero.git/dist/lib/python/omero/clients.py in _initData(self, id)
    233                 msg = "No host specified. "
    234                 msg += "Use omero.client(HOSTNAME), ICE_CONFIG, or similar."
--> 235                 raise ClientError(msg)
    236 
    237             if not self.__ic:

ClientError: No host specified. Use omero.client(HOSTNAME), ICE_CONFIG, or similar.

[jmoore <josh@…>]

(In [275f9de7cad20282970dfd2eba75a3f31729d17b/ome.git] on branch develop) Catch EndpointParseException and throw ClientError in OmeroClients (Fix #6322)