getBlitzConnection review

[atarkowska]

webgateway.getBlitzConnection handle many different ways of creating and storing connection. This needs to be reviewed.

Currently there are three ways of creating connection:

• A per-process dictionary of StoredConnection? based connections (key = "C:$base") is kept.
• A per-process dictionary of session created connections (key = "S:$session_id") is kept.
• Another set of connections (key = "C:$server_id") is also kept, for creating 'guest' connections using with_session=False.

[atarkowska]

Referencing ticket #6342 has changed sprint.

[atarkowska]

Referencing ticket #6342 has changed sprint.

[cxallan]

First version of the connection retrieval and processing workflow

[cxallan]

Attached is now a connection retrieval flow chart that attempts to, at least at a high level, explain the process that must be undertaken to adequately retrieve, validate and keep alive an OMERO.web/OMERO.server connection pair. In order for this to work adequately, the following must be achieved:

1. Removal of reliance on StoredConnection or similar by using the omero.web.public.* settings
2. Extension of the OMERO.server share infrastructure to allow appropriate context switching in order to prevent:
   1. Username and password from being stored in the session
   2. Session creation being required for shares to be queried

[cxallan]

Second version of the connection retrieval and processing workflow

[cxallan]

After discussion with Ola added some clarifications and the "Session key in Django request" element of the workflow.

[cxallan]

Third version of the connection retrieval and processing workflow

[jmoore]

Moved from sprint 2012-01-31 (7)

[cxallan]

An initial version of the new decorator based connection handling logic is now available on my decorator branch:

• ​https://github.com/chris-allan/openmicroscopy/tree/6343_conn_decorator

I'll update the diagram with some further workflow information as soon as I get a chance.

[cxallan]

Fourth version of the connection retrieval and processing workflow

[cxallan]

Some additional work was also done by Carlos, which should be reviewed to make sure everything is covered in the following pull request:

• ​https://github.com/openmicroscopy/openmicroscopy/pull/45

[cxallan]

Also to be taken into account:

• ​http://trac.openmicroscopy.org.uk/ome/ticket/4245

[cxallan]

Review complete. Functional decorator now in the 6343_conn_decorator branch. Integration example with OMERO.web in a new branch 6342_integration.

• ​https://github.com/chris-allan/openmicroscopy/tree/6343_conn_decorator
• ​https://github.com/chris-allan/openmicroscopy/tree/6342_integration

[cxallan]

Fifth version of the connection retrieval and processing workflow

[cxallan]

Sixth version of the connection retrieval and processing workflow

[atarkowska]

While the inactive user tries to log in to the omero the error SecurityViolation? exception (serverStackTrace = ome.conditions.SecurityViolation?: No matching roles found in [guest] for session de58efec-6f18-4819-9f9d-1a02c7202db7 (allowed: [user])) could be handled better that rather then throw the exception. see ​#4245

[wmoore]

This is now implemented. Only remaining task is docs: #8545.

Closing...

[atarkowska]

Reopening as getBlitzConnection is still in the webgateway code. I will remove it from the code.

[atarkowska]

_session_logout also needs to be removed as is no longer valid

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [198794a2c4e4c4f0620c30731c35ae2806cae44c/ome.git] on branch develop) removing getBlitzConnection, see #6341

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [94b03977be8ce98b73fd53c50769101238878b4a/ome.git] on branch develop) removing _session_logout, see #6341

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [6a8656356d75c3152c0d145d26b83ec527b5b5a4/ome.git] on branch develop) removing getBlitzConnection, see #6341

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [56266bfaa45549242748da82b169b9f5c3a7d291/ome.git] on branch develop) removing _session_logout, see #6341

[wmoore]

Docs for this workflow are now at ​http://trac.openmicroscopy.org.uk/ome/wiki/OmeroWeb/WritingViews