Task #6343 (closed)
Opened 13 years ago
Closed 12 years ago
Webclient decorators review
| Reported by: | atarkowska | Owned by: | cxallan |
|---|---|---|---|
| Priority: | blocker | Milestone: | OMERO-4.4 |
| Component: | Web | Version: | n.a. |
| Keywords: | n.a. | Cc: | web-team@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2012-01-17 (6) |
Description (last modified by atarkowska)
- isUserConnected should be reviewed
- checkVersion should be implemented based on webadmin._checkVersion
Tickets for particular tasks will be created separately under the main story
Change History (15)
comment:1 Changed 13 years ago by atarkowska
- Milestone OMERO-Beta4.3.2 deleted
- Sprint 2011-08-04 (2) deleted
comment:2 Changed 13 years ago by atarkowska
comment:3 Changed 13 years ago by atarkowska
- Milestone set to Unscheduled
comment:4 Changed 13 years ago by atarkowska
- Description modified (diff)
- Summary changed from Webclient decorators to Webclient decorators review
comment:5 Changed 13 years ago by atarkowska
- Description modified (diff)
comment:6 Changed 13 years ago by atarkowska
Referencing ticket #6342 has changed sprint.
comment:7 Changed 12 years ago by cxallan
- Owner changed from atarkowska to cxallan
- Remaining Time set to 1.0
- Status changed from new to accepted
comment:8 Changed 12 years ago by cxallan
- Milestone changed from Unscheduled to OMERO-Beta4.4
- Sprint set to 2011-12-13 (4)
comment:9 Changed 12 years ago by wmoore
Some ideas for a decorator for various template/json tasks: See http://github.com/will-moore/openmicroscopy/commit/322f9e6fae3f15330b9847f8d2924ac6b61c5b0d
comment:10 Changed 12 years ago by cxallan
- Cc web-team@… added
- Priority changed from major to blocker
- Remaining Time changed from 1.0 to 0.75
An initial version of a replacement for isUserConnected is now available:
comment:11 Changed 12 years ago by jburel
- Sprint changed from 2011-12-13 (4) to 2011-12-27 (5)
Moved from sprint 2011-12-13 (4)
comment:12 Changed 12 years ago by cxallan
- Remaining Time changed from 0.75 to 0.1
Review largely completed. There are now some more commits on that branch that encompass all the functionality of:
- @isUserConnected
- @isAdminConnected
- @isOwnerConnected
- webgateway, webclient and webadmin usage of getBlitzConnection(...), reaction to None, exceptions, etc.
To finish the review what needs to be evaluated are the exit conditions of on_not_logged_in(...), various pieces of exception handling and addressing the uniform usage of the various required **kwargs variables for each view method.
comment:13 Changed 12 years ago by jburel
- Sprint changed from 2012-01-03 (5) to 2012-01-17 (6)
Moved from sprint 2012-01-03 (5)
comment:14 Changed 12 years ago by cxallan
Discussion between Will, Ola and myself today went over the 6343_conn_decorator branch and we're largely happy with where it is now. I'm going to close this ticket as is with a discussion to happen during the web meeting on Monday January 9th to decide the further directions for the decorators.
comment:15 Changed 12 years ago by cxallan
- Remaining Time changed from 0.1 to 0
- Status changed from accepted to closed
Referencing ticket #6342 has changed sprint.