Task #6361 (closed)
chgrp: refactor DEL-specific GraphState code
| Reported by: | jamoore | Owned by: | jamoore |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-Beta4.3.2 |
| Component: | General | Version: | n.a. |
| Keywords: | n.a. | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2011-08-18 (3) |
Description
Unfortunately, several classes in the ome.services.graphs package assume that they are being used for delete (i.e. the code move from #3620 was not a complete refactoring). Any delete specific code should probably be moved to DeleteStep.
Change History (6)
comment:1 Changed 13 years ago by jmoore
- Status changed from new to accepted
comment:2 Changed 13 years ago by cxallan
- Sprint changed from 2011-08-04 (2) to 2011-08-18 (3)
comment:3 Changed 13 years ago by jmoore
Refactoring done on branch (pushed to team/feature-chgrp though needs rebasing). Required removing the "runTopLevel" logic from AnnotationGraphSpec and putting it in DeleteStep. Each concrete step type looks to be the proper place to add such handling. Now it is time to start handling the validation of the actions (i.e. current commit blindly changes the groups without testing validity): #6422
comment:4 Changed 13 years ago by jmoore
- Remaining Time changed from 1 to 0
- Resolution set to fixed
- Status changed from accepted to closed
comment:5 Changed 13 years ago by jmoore <josh@…>
(In [7c6c4f58506c718b5a9f725e8f2962d3f40e8112/ome.git] on branch develop) Refactor DEL out of SPEC (See #6361)
comment:6 Changed 13 years ago by jmoore <josh@…>
(In [1f864b35b235cbd5f8ba0fb9376aa576c8e5c1ba/ome.git] on branch develop) Working chgrp test (Fix #6361)
Moved from sprint 2011-08-04 (2)