Task #6387 (closed)
Bug: assert_re and rendering engine preparation
Reported by: | cxallan | Owned by: | cxallan |
---|---|---|---|
Priority: | blocker | Milestone: | OMERO-Beta4.3.2 |
Component: | OmeroPy | Version: | n.a. |
Keywords: | n.a. | Cc: | python-team@… |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | 0.0d |
Sprint: | 2011-08-04 (2) |
Description
Since the closure of #4642 by [476842836e8047ae81f0375f30814198c79a6ad3/ome.git] it is possible that the exceptions thrown during the preparation of the rendering engine by ImageWrapper._prepareRenderingEngine() will be caught and None returned. In addition there were changes to ensure that ImageWrapper.getChannels() works for big images that have not had their pyramid created yet in #5539 by [6efc0cd9ed00317e7ae5438a7115463462390077/ome.git]
With this being the case we have severe problems when callers of functions that have an @assert_re decorator are expecting a non-None return value.
Potential changes that may have to happen are:
- Reversion of the BlitzGateway changes performed in [476842836e8047ae81f0375f30814198c79a6ad3/ome.git]
- Changes to ImageWrapper.getChannels() in combination with changes to @assert_re
Resolution of the above issues is required to have the work that is being done on #6365 functional.
Change History (8)
comment:1 Changed 13 years ago by cxallan
comment:2 Changed 13 years ago by cxallan
- Status changed from new to accepted
comment:3 Changed 13 years ago by cxallan
BlitzGateway methods protected by assert_re:
* _getProjectedThumbnail * getChannels * getRenderingModels * getRenderingModel * renderJpegRegion * renderJpeg * createMovie * renderRowLinePlotGif * renderColLinePlotGif * getZ * getT * getDefaultZ * getDefaultT * saveDefaults
Prospective changes on team/feature/6387.
comment:4 Changed 13 years ago by cxallan
- Remaining Time changed from 0.5 to 0.1
comment:5 Changed 13 years ago by atarkowska
Once we test new implementation and make a decision about general strategy for decorators new tasks should be put in the Story #6342
comment:6 Changed 13 years ago by Chris Allan <callan@…>
- Remaining Time changed from 0.1 to 0
- Resolution set to fixed
- Status changed from accepted to closed
(In [b24b0cfa078e659f828ad0ac9779e17eb453df44/ome.git] on branch develop) Merge branch 'feature/6387' into develop
Closes #6387.
comment:7 Changed 13 years ago by Aleksandra Tarkowska <atarkowska@…>
(In [c7c92b6bb618f6db68cc992efe0d74e8b7079367/ome.git] on branch develop) this override the getChannels in webclient gateway, see #6387
comment:8 Changed 13 years ago by Aleksandra Tarkowska <atarkowska@…>
(In [5a4e00b9ea8ab58cdb059c54781fadb165e99403/ome.git] on branch develop) this override the getChannels in webclient gateway, see #6387
Example exception that can currently be raised if an Ice.ObjectNotExistException is thrown when preparing the rendering engine: