Remove 'Experimenter' methods from BlitzGateway

[wmoore]

Aim to remove these methods from BlitzGateway? since their functionality is now covered by getObject() or getObjects()

• getExperimenter(eid)
• listExperimenters()
• findExperimenter(userName)

Need to check or write new tests to confirm that these methods behave the same as:

• getObject("Experimenter", eid)
• getObjects("Experimenter")
• getObject("Experimenter", attributes={"omeName", name})

Document any differences in Exception handling or return type (E.g. if >1 found for getObject() or None found etc.

[Will Moore <will@…>]

(In [d336dee1b37be8cbe075b97bcb620f8c9669d6fa/ome.git] on branch develop) Adding tests for replacing findExperimenter and listExperimenters. See #6394

[wmoore]

Current use of conn.getExperimenter(eid):

wjm:tools will$ grep "getExperimenter(" -r OmeroWeb/
OmeroWeb/omeroweb/webadmin/controller/experimenter.py:            self.experimenter = self.conn.getExperimenter(eid)
OmeroWeb/omeroweb/webadmin/tests/unittests.py:            exp = conn.getExperimenter(eid)
OmeroWeb/omeroweb/webadmin/views.py:                exp = conn.getExperimenter(eid)
OmeroWeb/omeroweb/webclient/controller/container.py:            self.experimenter = self.conn.getExperimenter(eid)
OmeroWeb/omeroweb/webclient/controller/container.py:            self.experimenter = self.conn.getExperimenter(eid)  
OmeroWeb/omeroweb/webclient/controller/container.py:            self.experimenter = self.conn.getExperimenter(eid)
OmeroWeb/omeroweb/webclient/controller/container.py:            self.experimenter = self.conn.getExperimenter(eid)
OmeroWeb/omeroweb/webclient/webclient_gateway.py:        self._user = self.getExperimenter(self._userid)
OmeroWeb/omeroweb/webclient/webclient_gateway.py:        self._user = self.getExperimenter(self._userid)
OmeroWeb/omeroweb/webclient/webclient_gateway.py:            self._user = self.getExperimenter(self._userid)
OmeroWeb/omeroweb/webmobile/views.py:        experimenter = conn.getExperimenter(eid)
OmeroWeb/omeroweb/webmobile/views.py:        experimenter = conn.getExperimenter(eid)
OmeroWeb/omeroweb/webmobile/views.py:        experimenter = conn.getExperimenter(eid)
OmeroWeb/omeroweb/webmobile/views.py:        experimenter = conn.getExperimenter(eid)
OmeroWeb/omeroweb/webmobile/views.py:    exp = conn.getExperimenter(conn.getEventContext().userId)

[wmoore]

wjm:tools will$ grep "getExperimenter(" -r OmeroWeb/
wjm:tools will$ grep "findExperimenter(" -r OmeroWeb/
wjm:tools will$ grep "listExperimenters" -r OmeroWeb/
wjm:tools will$ 

After removing use of conn.getExperimenter(eid) from OmeroWeb, tested

• webadmin
  • create experimenter
  • edit experimenter
  • create group
  • edit group's members
  • edit group's leaders
• webmobile:
  • Browse users in group - see their data
• webclient
  • Browse P/D/I
  • Switch users and groups - data filtered OK

[Will Moore <will@…>]

(In [22bf17f230666a4452e76e6152be6797b9377fd8/ome.git] on branch develop) Removing use of conn.getExperimenter(eid) from OmeroWeb. See #6394

[Will Moore <will@…>]

(In [fbe6629d87d025465c28121430170d20abf3a5a5/ome.git] on branch develop) Removing getExperimenter() from blitz gateway. See #6394

[Will Moore <will@…>]

(In [13321fc75d67e15481732fdc28f9d3c4f9a1e3d9/ome.git] on branch develop) Removing listExperimenters() from blitz gateway. See #6394

[Will Moore <will@…>]

(In [d307e29a64552a588287e5dbc7436b3532c57398/ome.git] on branch develop) Removing findExperimenter(omeName) from blitz gateway. See #6394

[Will Moore <will@…>]

(In [50d32aee19c2ee6b29a3dfc4229e023a6ff11f2e/ome.git] on branch develop) Removing use of blitz listExperimenters() from gatewaytests. See #6394

[Will Moore <will@…>]

(In [0a9a3bdb7f8e0e806518692870158ac13977ff0e/ome.git] on branch develop) Removing use of blitz findExperimenter(omeName) from gatewaytest. See #6394