Bug: Script runner and pop-up blockers

[cxallan]

When clicking "Run Script" and a pop-up blocker is enabled, it is triggered.

[cxallan]

Screenshot of the blocked pop-up

[wmoore]

Investigations on Firefox with popup blocker enabled:

• The Script window triggers the popup blocker even if:
  • I use a link to trigger javascript script running
  • I use openPopup() function to do the launching
• It doesn't trigger popup blocker if I do <a href="#" onClick="openPopup('activities/');">Run Script</a>

It seems that the popup blocker is more sensitive on the script window than on the main page, possibly because this is a window opening a window.

Problems with opening window directly from the link:

• The main webclient window is not the 'opener' so I can't browse from the Activities window back to main webclient window.
• I can't open the window in response to successful script submission

[wmoore]

Made some changes to work around popup blocker

• Instead of opening 'Activities' on AJAX success of runScript(), I open 'Activities' directly
• Any errors generated by runScript() are now saved to session['callback'][timestamp] and displayed in 'Activities' window
• Errors submission is now in 'Activities' window instead of script_ui
• This means that not all the keys in session['callback'] are job IDs.

[Will Moore <will@…>]

(In [b65de81804919365c587d0c4b22c0c1d3c24bec0/ome.git] on branch develop) Web runScript errors added to sessioncallback? to be displayed in 'Activities' window. Closes #6435