Bug: NPE in DeleteHandleI

[jamoore]

                            // Now any tmp files
                            FileFilter tmpFileFilter = new WildcardFileFilter("."
                                    + id + PixelsService.PYRAMID_SUFFIX + "*.tmp");
                            File[] tmpFiles = dir.listFiles(tmpFileFilter);
/// THIS CAN BE NULL
                            for (int i = 0; i < tmpFiles.length; i++) {
                                if(!deleteSingleFile(tmpFiles[i])) {
                                    failedMap.get(fileType).add(id);
                                    filesFailed++;
                                    bytesFailed += tmpFiles[i].length();
                                }

can throw an NPE:

estDeleteFullImage on instance null(integration.DeleteServiceTest) 0.839s omero.InternalException
    serverStackTrace = "java.lang.NullPointerException
                        at ome.services.blitz.impl.DeleteHandleI.deleteFiles(DeleteHandleI.java:503)
                        at ome.services.blitz.impl.DeleteHandleI.run(DeleteHandleI.java:354)
                        at ome.services.blitz.impl.DeleteI.makeAndRun(DeleteI.java:196)
                        at ome.services.blitz.impl.DeleteI$1.call(DeleteI.java:91)
                        at ome.services.throttling.Callback2.run(Callback2.java:49)
                        at ome.services.throttling.InThreadThrottlingStrategy.safeRunnableCall(InThreadThrottlingStrategy.java:80)
                        at ome.services.blitz.impl.AbstractAmdServant.safeRunnableCall(AbstractAmdServant.java:156)
                        at ome.services.blitz.impl.DeleteI.deleteImage_async(DeleteI.java:88)
                        at omero.api._IDeleteTie.deleteImage_async(_IDeleteTie.java:81)
                        at omero.api._IDeleteDisp.___deleteImage(_IDeleteDisp.java:205)
                        at omero.api._IDeleteDisp.__dispatch(_IDeleteDisp.java:378)
                        at IceInternal.Incoming.invoke(Incoming.java:159)
                        at Ice.ConnectionI.invokeAll(ConnectionI.java:2037)
                        at Ice.ConnectionI.message(ConnectionI.java:972)
                        at IceInternal.ThreadPool.run(ThreadPool.java:577)
                        at IceInternal.ThreadPool.access$100(ThreadPool.java:12)
                        at IceInternal.ThreadPool$EventHandlerThread.run(ThreadPool.java:971)
                        "
    serverExceptionClass = "java.lang.NullPointerException"
    message = ""

[jburel]

Sometimes the test passes, sometimes it fails.

[Colin Blackburn <C.Blackburn@…>]

(In [63d07a9553b3185646ce5dd8b03c83af53555738/ome.git] on branch develop) Avoid trying to delete temporary files when there aren't any. See #6595