Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #6609 (closed)

Opened 8 years ago

Closed 8 years ago

BUG: Import DV inconsistent inclusion of ini file

Reported by: ajpatterson Owned by: bwzloranger
Priority: minor Milestone: OMERO-Beta4.3.2
Component: Import Version: n.a.
Keywords: n.a. Cc:
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-09-15 (5)

Description

In importer:

If I select all the files in the dv folder it skips adding the .ini files to the queue. If I only select some of the files in the folder and add them to the queue then the .ini file is added and gives an error on import.

Attachments (1)

6609-fix.diff (905 bytes) - added by mlinkert-x 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by mlinkert

  • Owner set to mlinkert-x
  • Sprint set to 2011-09-01 (4)

comment:2 Changed 8 years ago by mlinkert

Short of actually picking the test_setup.ini file and adding it to the queue, I can't reproduce this. Is there any chance that you explicitly picked that file? If not, which specific files cause the .ini file to be added to the queue?

When the .ini file was imported, did you see an error other than "Unknown file format"?

comment:3 Changed 8 years ago by ajpatterson

Yes, I am picking the file specifically.

The odd thing was the inconsistency, if I select all the files in the folder, then hit add, it ignores the .ini but if I just select some of the files including the .ini and then hit add the .ini is included.

On further testing:

  • If I select 5 or fewer files including the .ini then it is included in the queue.
  • If I select 6 or more files including the .ini then it is not added to the queue.

When you select Import the .ini does give the correct Unknown file format exception.

comment:4 Changed 8 years ago by mlinkert

  • Owner changed from mlinkert-x to bwzloranger

Thanks for the additional information Andrew. This is actually not a problem with Bio-Formats, but has to do with how the importer processes file candidates. If you picked one of the .log or .txt files, then the .ini file will not be included; if you only picked .dv files and the .ini, then the .ini is included.

Brian, a patch is attached that ought to fix this problem (it just adds the '.ini' extension to the list of extensions that trigger import candidate processing). If it looks sensible, feel free to commit and close the ticket.

Changed 8 years ago by mlinkert-x

comment:5 Changed 8 years ago by jburel

  • Sprint changed from 2011-09-01 (4) to 2011-09-15 (5)

Moved from sprint 2011-09-01 (4)

comment:6 Changed 8 years ago by bwzloranger <bwzloranger@…>

  • Remaining Time set to 0
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.80511 sec.)

We're Hiring!