Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #6889 (closed)

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

Review Java page

Reported by: jburel Owned by: cblackburn
Priority: minor Milestone: OMERO-Beta4.3.2
Component: General Version: n.a.
Keywords: n.a. Cc: saloynton, jamoore, wmoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-09-29 (6)

Description

This page requires a review to ensure the material is correct and has suitable examples to be used in the training material.

http://trac.openmicroscopy.org.uk/ome/wiki/OmeroJava

Change History (6)

comment:1 Changed 13 years ago by jburel

  • Milestone changed from OMERO-Beta4.3.3 to OMERO-Beta4.3.2
  • Sprint changed from 2011-10-13 (1) to 2011-09-29 (6)

comment:2 Changed 13 years ago by jburel

  • Owner set to cblackburn

comment:3 Changed 13 years ago by cblackburn

  • Remaining Time set to 0.15
  • Status changed from new to accepted

comment:4 Changed 13 years ago by cblackburn

  • Remaining Time changed from 0.15 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed

This looks okay and the examples look fine and comprehensive. I've corrected some mark-up to tidy things up.

One question? In the first code snippet,

client client = new client(hostName, port);
ServiceFactoryPrx entry = client.createSession(userName, password);
// if you want to have the data transfer encrypted then you can 
// use the entry variable otherwise use the following 
client unsecureClient = client.createClient(false);

would omero.client client = ... be clearer? (Not sure what the surrounding code and imports look like.

comment:5 Changed 13 years ago by jmoore

colin: probably, and it certainly can't hurt to have the explicit omero.client. we do the same for many of the ice calls as well.

comment:6 Changed 13 years ago by jburel

Documentation added for "Create Image"

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.69250 sec.)

We're Hiring!