Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #6953 (closed)

Opened 13 years ago

Closed 12 years ago

Java Code style template

Reported by: jburel Owned by: jamoore
Priority: minor Milestone: OMERO-4.4
Component: General Version: n.a.
Keywords: n.a. Cc: omero-team@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: n.a.

Description

Review and update the existing code style template currently available as part of the insight code base.

Attachments (1)

CodeTemplate (3.6 KB) - added by jburel 13 years ago.

Download all attachments as: .zip

Change History (24)

comment:1 Changed 13 years ago by jburel

  • Owner set to jburel
  • Sprint set to 2011-10-27 (1)

Changed 13 years ago by jburel

comment:2 Changed 13 years ago by jburel

  • Cc mlinkert-x added

Need to review eclipse formatting template.
I have attached the code template to the ticket.
e.g. Points to unify:

  • header of the files (insight, loci very similar, server code no)
  • tab vs space.
  • ensure author name is there
  • import class rules i.e. java.util.List vs java.util.*
  • etc.
Last edited 13 years ago by jburel (previous) (diff)

comment:3 Changed 13 years ago by jburel

Mini-group discussion on Friday??

comment:4 Changed 13 years ago by jmoore

Can do. Afternoon for Melissa?

comment:5 Changed 13 years ago by jburel

  • Sprint changed from 2011-10-27 (1) to 2011-11-10 (2)

Moved from sprint 2011-10-27 (1)

comment:6 Changed 12 years ago by jburel

Could we finalize that next week?

comment:7 Changed 12 years ago by jburel

  • Sprint changed from 2011-11-10 (2) to 2011-11-29 (3)

Moved from sprint 2011-11-10 (2)

comment:8 Changed 12 years ago by jmoore

I think so. Probably should have done this in person, but as long as we put aside a good hour or so... :)

comment:9 Changed 12 years ago by jmoore

  • Cc omero-team@… added; jmoore cxallan mlinkert-x removed

From Andrew:

I have always preferred

   if ()
   {
       dsfsdfsd
   }
   else
   {
       sdasd
   }
In fact all brackets on there own lines. I find the extra white space makes code much more readable.

comment:10 Changed 12 years ago by jburel

  • Milestone changed from OMERO-Beta4.4 to 3.0-M2
  • Sprint changed from 2011-11-29 (3) to 2011-12-27 (5)

Decision to be done while meeting in Dresden

comment:11 Changed 12 years ago by jmoore

  • Milestone changed from 3.0-M2 to OMERO-Beta4.4
  • Sprint 2011-12-27 (5) deleted

comment:12 Changed 12 years ago by jmoore

  • Sprint set to 2011-12-27 (5)

comment:13 Changed 12 years ago by jburel

  • Owner changed from jburel to jmoore

Outcome of discussion in Dresden between Josh, Melissa J-M: (12/12/11)

comment:14 Changed 12 years ago by jmoore

  • Owner jmoore deleted
  • Sprint changed from 2012-01-03 (5) to 2012-01-31 (7)

I'm going to assume we won't try to get this merged in until after the bug sprint (6), so I'm pushing to 7. I've just opened a PR (https://github.com/openmicroscopy/openmicroscopy/pull/49) with the ant target (ant format) and most of the configuration from the CodeTemplate file as eclipse .settings. It would be good if others could review. Removing myself as owner for the moment.

comment:15 Changed 12 years ago by jmoore

  • Owner set to jmoore

comment:16 Changed 12 years ago by jmoore

  • Remaining Time set to 0.5

Current task is to write an Eclipse CleanUpApplication or to find another code clean-up tool.

comment:17 Changed 12 years ago by jmoore

  • Sprint changed from 2012-01-31 (7) to 2012-02-14 (8)

Moved from sprint 2012-01-31 (7)

comment:18 Changed 12 years ago by jburel

  • Sprint changed from 2012-02-14 (8) to 2012-02-28 (9)

Moved from sprint 2012-02-14 (8)

comment:19 Changed 12 years ago by jburel

  • Sprint changed from 2012-02-28 (9) to 2012-03-13 (10)

Moved from sprint 2012-02-28 (9)

comment:20 Changed 12 years ago by jburel

  • Sprint changed from 2012-03-13 (10) to 2012-03-27 (11)

Moved from sprint 2012-03-13 (10)

comment:21 Changed 12 years ago by jburel

  • Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)

Moved from sprint 2012-03-27 (11)

comment:22 Changed 12 years ago by jmoore

  • Sprint 2012-04-10 (12) deleted

Away for this sprint.

comment:23 Changed 12 years ago by sbesson

  • Remaining Time changed from 0.5 to 0
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.72203 sec.)

We're Hiring!