Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #726 (closed)

Opened 17 years ago

Closed 16 years ago

Review log4j.xml and significantly reduce logging level

Reported by: jamoore Owned by: jamoore
Priority: minor Milestone: 3.0-Beta3.1
Component: Performance Version: 3.0-M1
Keywords: logging Cc:
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

The logging level is definitely affecting performance. Just how much isn't completely clear yet, but it's certainly a lot (in fact, the calls to log4j can hang the entire server if standard out doesn't flush fast enough).

See #725

Change History (5)

comment:1 follow-up: Changed 17 years ago by cxallan

We should also look into ensuring that:

  • there are no e.printStackTrace()'s anywhere (they just make debugging using the server.log kinda impossible)
  • instances of System.err or System.out are removed from the codebase

comment:2 in reply to: ↑ 1 Changed 17 years ago by jmoore

Replying to callan:

We should also look into ensuring that:

  • instances of System.err or System.out are removed from the codebase

See #383

comment:3 Changed 16 years ago by jmoore

  • Milestone changed from 3.0-RC1 to 3.0-Beta3.1
  • Status changed from new to assigned

comment:4 Changed 16 years ago by jmoore

The plan:

  • port etc/log4j.properties to etc/log4j.xml -- this allows more consistent reuse between blitz and jboss. This requires modifying omero/java.py to set -Dlog4j.configuration=file:etc/log4j.xml since the default log4j configuration searches for log4j.properties.
  • reduce logging as much as possible -- since our error handlers log all exceptions levels can be significantly reduced. Also, having them explicitly listed allows users to more easily selectively increasing logging later if problems arise.

comment:5 Changed 16 years ago by jmoore

  • Resolution set to fixed
  • Status changed from assigned to closed

r2799 contains this fix. WebAdmin? still has its own log4j.properties file (for creating JBOSS_HOME/server/default/log/WebAdmin.log) and so shouldn't be affected by this change.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.63588 sec.)

We're Hiring!