BUG: param range miscalculated

[atarkowska]

Referring to #7305 script misinterpret range values when they are set to '0'. The problem is in calculateRanges where commandArgs "T_End" and "Z_End" is 0 is treated as entire range rather then particular plane. Giving commandArgs= {"Z_Start":0, "Z_End":0,"T_Start": 1, "T_End": 5} will make movie for entire Z range and T in (1-5) rather then generate movie for first plane and T in (1-5)

Instead of:

if "Z_Start" in commandArgs and commandArgs["Z_Start"] = 0 and commandArgs["Z_Start"] < sizeZ:
        zStart = commandArgs["Z_Start"]
if "Z_End" in commandArgs and commandArgs["Z_End"] = 0 and commandArgs["Z_End"] < sizeZ:
        zEnd = commandArgs["Z_End"]+1

should be:

if "Z_Start" in commandArgs and commandArgs["Z_Start"] >= 0 and commandArgs["Z_Start"] < sizeZ:
        zStart = commandArgs["Z_Start"]
if "Z_End" in commandArgs and commandArgs["Z_End"] >= 0 and commandArgs["Z_End"] < sizeZ:
        zEnd = commandArgs["Z_End"]+1

[jburel]

The script was initially only used from the viewer where the default z (resp. t) was used to set the plane. Now that we use it from other location it makes sense to adjust.
Changing the logic of the script is valid but we will have to announce it when we release so we reduce the impact.
I will review that when I come back.

You should have a scripts review sprint (e.g. #7102) to improve error handling and parameters check.

[jmoore]

Moved from sprint 2011-11-29 (3)

[wmoore]

Fixed by commit: ​http://github.com/will-moore/openmicroscopy/commit/bb4b28074f10fadf502d3e0f1a8e6c25d9a40743

[Will Moore <will@…>]

(In [bb4b28074f10fadf502d3e0f1a8e6c25d9a40743/ome.git] on branch develop) Fix Z/T ranges in Make_Movie.py. Closes #7306