Removal of e.printStackTrace() from the codebase

[cxallan]

There should be no locations where e.printStackTrace() is used as it only drops debugging information on the console.

For example:

try
{
    compressThumbnailToDisk(metadata, image);
}
catch (IOException e)
{
    e.printStackTrace();
    throw new ResourceError(e.getMessage());
}

should be...

try
{
    compressThumbnailToDisk(metadata, image);
}
catch (IOException e)
{
    final Writer result = new StringWriter();
    final PrintWriter printWriter = new PrintWriter(result);
    e.printStackTrace(printWriter);
    log.error(result.toString());
    throw new ResourceError(e.getMessage() + " Please check server log.");
}

If needed, the logger should be created in the class as follows:

/** The logger for this class. */
private static Log log = LogFactory.getLog(ThumbnailBean.class);

[jmoore]

Can I suggest:

void Log.error(java.lang.Object message, java.lang.Throwable t) 

[cxallan]

Replying to jmoore:

Can I suggest:

void Log.error(java.lang.Object message, java.lang.Throwable t) 

Looks perfect.

[cxallan]

Okay, so to use Josh's spiffy Log method:

try
{
    compressThumbnailToDisk(metadata, image);
}
catch (IOException e)
{
    e.printStackTrace();
    throw new ResourceError(e.getMessage());
}

should be...

try
{
    compressThumbnailToDisk(metadata, image);
}
catch (IOException e)
{
    log.error("Failure compressing thumbnail", e);
    throw new ResourceError(e.getMessage() + " Please check server log.");
}

[dwhitehurst-x]

Was handled like so ...

try
{
    compressThumbnailToDisk(metadata, image);
}
catch (IOException e)
{
    if (log.isDebugEnabled()) {
        log.debug("Failure compressing thumbnail", e);
    }
    throw new ResourceError(e.getMessage() + " Please check server log.");
}