Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #7314 (closed)

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

Bug: handle deletion of fileannotations

Reported by: jamoore Owned by: jamoore
Priority: major Milestone: OMERO-4.4.4
Component: Services Version: n.a.
Keywords: n.a. Cc: jburel, wmoore, atarkowska, cxallan, cneves
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-08-28 (3)

Description

~/git/dist $ bin/omero delete /OriginalFile:28 /OriginalFile:27 /OriginalFile:26 /OriginalFile:22 /OriginalFile:21 /OriginalFile:20
Deleting /OriginalFile 28... error
	error: ConstraintViolation: fkfileannotation_file_originalfile
Deleting /OriginalFile 27... error
Deleting /OriginalFile 26... error
Deleting /OriginalFile 22... error
Deleting /OriginalFile 21... error
Deleting /OriginalFile 20... error

Primary difficulty is deciding on the default action. We can use "KEEP" for the non-default.

Change History (28)

comment:1 Changed 10 years ago by jmoore

  • Cc wmoore atarkowska cxallan cneves-x added
  • Sprint set to 2012-01-17 (6)

Everyone ok with having the fileannotation (and xyzAnnotationLinks, etc) removed when deleting an original file. Pushing a failing test to my sprint6-server-backlog branch:

     [exec] ======================================================================
     [exec] FAIL: test7314 (integration.delete.TestDelete)
     [exec] ----------------------------------------------------------------------
     [exec] Traceback (most recent call last):
     [exec]   File "/Users/moore/GlencoeSoftware.git/git/omero.git/components/tools/OmeroPy/test/integration/delete.py", line 485, in test7314
     [exec]     self.assertEquals(0, errors, "Found errors:\n\t" + reports)
     [exec] AssertionError: Found errors:
     [exec] 	ConstraintViolation: fkfileannotation_file_originalfile

comment:2 Changed 10 years ago by wmoore

Sounds fine to me. I guess it's up to the clients to check, E.g. whether anyone else has used MY file in their annotations etc.

comment:3 Changed 10 years ago by jmoore

The other option is to null the file column to keep a record of the fact that there was an annotation. If we allowed that, it would be configurable.

comment:4 Changed 10 years ago by jburel

see #4341

comment:5 Changed 10 years ago by jmoore

Jean-Marie's vote: delete the fileann if deleting the originalfile.

comment:6 Changed 10 years ago by wmoore

I agree: delete the fileann if deleting the originalfile. Users would get pretty confused by having a File Annotation with no file.

comment:7 Changed 10 years ago by jmoore

  • Remaining Time changed from 0.25 to 0.5
  • Status changed from new to accepted

comment:8 Changed 10 years ago by jburel

  • Sprint changed from 2012-01-17 (6) to 2012-01-31 (7)

Moved from sprint 2012-01-17 (6)

comment:9 Changed 10 years ago by jmoore <josh@…>

(In [41e952d53baa1ef45c057c0fb528485a5fccdf14/ome.git] on branch develop) Failing test of ofile with fileann (See #7314)

comment:10 Changed 10 years ago by jmoore

  • Sprint changed from 2012-01-31 (7) to 2012-02-14 (8)

Moved from sprint 2012-01-31 (7)

comment:11 Changed 10 years ago by jburel

  • Sprint changed from 2012-02-14 (8) to 2012-02-28 (9)

Moved from sprint 2012-02-14 (8)

comment:12 Changed 10 years ago by jmoore

  • Owner jmoore deleted
  • Status changed from accepted to new

comment:13 Changed 10 years ago by jburel

  • Sprint changed from 2012-02-28 (9) to 2012-03-13 (10)

Moved from sprint 2012-02-28 (9)

comment:14 Changed 10 years ago by jburel

  • Sprint changed from 2012-03-13 (10) to 2012-03-27 (11)

Moved from sprint 2012-03-13 (10)

comment:15 Changed 10 years ago by jburel

  • Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)

Moved from sprint 2012-03-27 (11)

comment:16 Changed 10 years ago by jburel

  • Sprint changed from 2012-04-10 (12) to 2012-04-24 (13)

Moved from sprint 2012-04-10 (12)

comment:17 Changed 10 years ago by jburel

  • Sprint changed from 2012-04-24 (13) to 2012-05-08 (14)

Moved from sprint 2012-04-24 (13)

comment:18 Changed 10 years ago by jburel

  • Sprint changed from 2012-05-08 (14) to 2012-05-22 (15)

Moved from sprint 2012-05-08 (14)

comment:19 Changed 10 years ago by jburel

  • Sprint changed from 2012-05-22 (15) to 2012-06-05 (16)

Moved from sprint 2012-05-22 (15)

comment:20 Changed 10 years ago by jmoore

  • Owner set to jmoore

comment:21 Changed 10 years ago by jburel

  • Sprint changed from 2012-06-05 (16) to 2012-06-19 (17)

Moved from sprint 2012-06-05 (16)

comment:22 Changed 10 years ago by jmoore

  • Priority changed from minor to major

Has been seen by others during testing (Chris / Colin). Bumping.

comment:23 Changed 10 years ago by jburel

  • Sprint changed from 2012-06-19 (17) to 2012-07-03 (18)

Moved from sprint 2012-06-19 (17)

comment:24 Changed 10 years ago by jburel

  • Sprint changed from 2012-07-03 (18) to 2012-07-17 (19)

Moved from sprint 2012-07-03 (18)

comment:25 Changed 10 years ago by jmoore

  • Milestone changed from OMERO-Beta4.4 to OMERO-Beta4.4.1
  • Sprint 2012-07-17 (19) deleted

comment:26 Changed 9 years ago by jmoore

  • Remaining Time changed from 0.5 to 0
  • Resolution set to fixed
  • Sprint set to 2012-08-28 (3)
  • Status changed from new to closed

Tests look to all be passing. Pushed to https://github.com/openmicroscopy/openmicroscopy/pull/292

comment:27 Changed 9 years ago by jmoore <josh@…>

(In [e5ccdde7eb45f1cf12f4e1e67905a7ba869832e7/ome.git] on branch develop) Test and minor fixes for delete (See #7314)

Work on 7314 is happening on the chgrp branch, because it adds a new
requirement to how we work with graphs. Before, it was never possible to
walk "up" a graph, which is needed for handling file to file-annotation
issues.

comment:28 Changed 9 years ago by jmoore <josh@…>

(In [bc74d5768e6dd3e16c3a417adc8079ee78f07fea/ome.git] on branch develop) Delete tests all passing (Fix #7314)

Failing tests were disabled and a few minor shifts
in logic were corrected for. By large, however, this
looks to bring us back to where we were previously.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.70777 sec.)

We're Hiring!