Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #7780 (closed)

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

Bug: Server class should become as a part of the common location

Reported by: atarkowska Owned by: cneves
Priority: major Milestone: OMERO-4.4.4
Component: Web Version: n.a.
Keywords: n.a. Cc: cxallan, wmoore, cneves
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-09-25 (5)

Description

webadmin.custom_models should moved to webgateway, as it is needed by any app that wants to interact with the servers
14:56:29 Carlos Neves: (though settings.py is all we need, to be honest, but still). Its not webadmin specific at all
Ola: Does it make sense to move it to 'common lib' like decorators, see ticket #6342

Change History (31)

comment:1 Changed 9 years ago by cneves

I don't think common is the correct place for it because the Server class is used for accessing the configured server connections, thus being as close to omero.gateway as one can be but being web specific. Thus webgateway == omero.gateway web wrapper, this would be the logical place to put this, imo.

I am assuming my understanding of what the common app is correct, a base app holding all media needed to comply with the omeroweb framework. Having that, putting code that is used at the blitz connection handling layer there sounds to me like we're polluting it.

comment:2 Changed 9 years ago by jmoore

  • Sprint changed from 2012-01-31 (7) to 2012-02-14 (8)

Moved from sprint 2012-01-31 (7)

comment:3 Changed 9 years ago by jburel

  • Sprint changed from 2012-02-14 (8) to 2012-02-28 (9)

Moved from sprint 2012-02-14 (8)

comment:4 Changed 9 years ago by jburel

  • Sprint changed from 2012-02-28 (9) to 2012-03-13 (10)

Moved from sprint 2012-02-28 (9)

comment:5 Changed 9 years ago by atarkowska

  • Owner changed from atarkowska to cxallan

Chris, could you please decide what I should do with it? I can handle it when I get back

comment:6 Changed 9 years ago by jburel

  • Sprint changed from 2012-03-13 (10) to 2012-03-27 (11)

Moved from sprint 2012-03-13 (10)

comment:7 Changed 9 years ago by jburel

  • Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)

Chris is off, moving to next sprint

comment:8 Changed 9 years ago by cxallan

  • Sprint changed from 2012-04-10 (12) to 2012-04-24 (13)

comment:9 Changed 9 years ago by jburel

  • Sprint changed from 2012-04-24 (13) to 2012-05-08 (14)

Moved from sprint 2012-04-24 (13)

comment:10 Changed 9 years ago by jburel

  • Sprint changed from 2012-05-08 (14) to 2012-05-22 (15)

Moved from sprint 2012-05-08 (14)

comment:11 Changed 9 years ago by cxallan

  • Status changed from new to accepted

comment:12 Changed 9 years ago by jburel

  • Sprint changed from 2012-05-22 (15) to 2012-06-05 (16)

Moved from sprint 2012-05-22 (15)

comment:13 Changed 9 years ago by jburel

  • Sprint changed from 2012-06-05 (16) to 2012-06-19 (17)

Moved from sprint 2012-06-05 (16)

comment:14 Changed 9 years ago by jburel

  • Sprint changed from 2012-06-19 (17) to 2012-07-03 (18)

Moved from sprint 2012-06-19 (17)

comment:15 Changed 9 years ago by jburel

  • Sprint changed from 2012-07-03 (18) to 2012-07-17 (19)

Moved from sprint 2012-07-03 (18)

comment:16 Changed 9 years ago by jmoore

  • Milestone changed from OMERO-Beta4.4 to OMERO-Beta4.4.1
  • Sprint 2012-07-17 (19) deleted

Per Chris, moving to 4.4.1

comment:17 Changed 9 years ago by cxallan

  • Summary changed from Server class should become as a part of the common location to Bug: Server class should become as a part of the common location

comment:18 Changed 9 years ago by cxallan

comment:19 Changed 9 years ago by cxallan

  • Owner changed from cxallan to web-team@…

comment:20 Changed 9 years ago by wmoore

  • Priority changed from critical to major

comment:21 Changed 9 years ago by jmoore

  • Owner changed from web-team@… to cxallan

Re-assigning to Chris for clarification. I'm tempted to just push.

comment:22 Changed 9 years ago by cneves

  • Owner changed from cxallan to cneves-x

comment:23 Changed 9 years ago by cneves

Cherry-picked on top of current develop and fixed conflicts, also added some unittest fixes to cope with the changes to the library but webclient doesn't really have any proper unittesting and webadmin has a few failing tests that are probably failing for a long time now and are unrelated to these changes.

Current work being done on https://github.com/cneves/openmicroscopy/tree/tickets/7780_server and next step I'll incorporate this into JCB code where we have much better code coverage.

comment:24 follow-up: Changed 9 years ago by cneves

The branch above has been tested on the commercial side and so far it doesn't seem to be breaking anything.

Chris:

  • you have the time remaining on this ticket to 0.2; is there something else you want to get moved around or was that just for testing / cleanup
  • The logger.info('Haha') thing on connector.py, along with other logging attempts I did there made me realize logging isn't outputting anything on this module. Do you know why?

comment:25 in reply to: ↑ 24 ; follow-up: Changed 9 years ago by cxallan

Replying to cneves-x:

The branch above has been tested on the commercial side and so far it doesn't seem to be breaking anything.

Chris:

  • you have the time remaining on this ticket to 0.2; is there something else you want to get moved around or was that just for testing / cleanup

Pretty much just the testing and branch cleanup. I would go ahead and completely clean this up getting rid of the ugly merge commits and just cherry-pick the two commits and rewrite the history with your changes.

  • The logger.info('Haha') thing on connector.py, along with other logging attempts I did there made me realize logging isn't outputting anything on this module. Do you know why?

I don't know why and it was one of the things I wanted to investigate. The reason I put that in there was that I was having trouble debugging things and there was no logging coming from the module at all. That should be stripped out and cleaned up.

I also endevoured for there to be no code changes required for this largely other than the migration itself. Are the find() changes things that have just been broken on the open source side?

Last edited 9 years ago by cxallan (previous) (diff)

comment:26 Changed 9 years ago by jmoore

  • Sprint set to 2012-09-25 (5)

comment:27 in reply to: ↑ 25 Changed 9 years ago by cneves

Replying to cxallan:

Chris:

  • you have the time remaining on this ticket to 0.2; is there something else you want to get moved around or was that just for testing / cleanup

Pretty much just the testing and branch cleanup. I would go ahead and completely clean this up getting rid of the ugly merge commits and just cherry-pick the two commits and rewrite the history with your changes.

Doing that now.

  • The logger.info('Haha') thing on connector.py, along with other logging attempts I did there made me realize logging isn't outputting anything on this module. Do you know why?

I don't know why and it was one of the things I wanted to investigate. The reason I put that in there was that I was having trouble debugging things and there was no logging coming from the module at all. That should be stripped out and cleaned up.

I'm investigating this, but since time is a little pressed I'll probably move this to a new ticket

I also endevoured for there to be no code changes required for this largely other than the migration itself. Are the find() changes things that have just been broken on the open source side?

This change is much older than your branch but unittesting for webclient and webadmin being all but ignored lately the issue was never noticed. In the end it is unrelated to the ticket but needed for it to be correctly merged into develop, so I'm keeping the fixes unless you'd rather I do two tickets and two dependent PRs.

comment:29 Changed 9 years ago by jmoore

  • Remaining Time changed from 0.2 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed

Carlos, once you've opened a PR for review, go ahead and close the ticket.

comment:30 Changed 9 years ago by Carlos Neves <carlos@…>

(In [1b811e48f97cb83039eb88e8ba69db9bccea6dc9/ome.git] on branch develop) Move Server to omeroweb.connector. (See #7780)

comment:31 Changed 9 years ago by Carlos Neves <carlos@…>

(In [3260278b4633cf931777df141a095dfbf9df569b/ome.git] on branch develop) Aggregating scattered methods into omeroweb's Connector class (see #7780)

Taken from https://github.com/chris-allan/openmicroscopy/commit/033df2f930b7e27274f935d449dde0e6a5879817

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.145423 sec.)

We're Hiring!