Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #7794 (closed)

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

Annotations js cleanup

Reported by: wmoore Owned by: wmoore
Priority: major Milestone: OMERO-4.4
Component: Web Version: n.a.
Keywords: n.a. Cc: atarkowska, cxallan
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: 2012-01-31 (7)

Description

Try and reduce the amount of javascript that is imported on each load of the right-hand panel (in metadata_general.html and batch_annotate.html):

  • Move js libs up to containers.html
  • move common js code up to containers.html
  • Investigate cross-talk between dialog boxes etc. .dialog plugin creates elements that are not removed when panel is reloaded?

Change History (4)

comment:1 Changed 8 years ago by wmoore

  • Status changed from new to accepted

comment:2 Changed 8 years ago by wmoore

  • Resolution set to fixed
  • Status changed from accepted to closed

Not going to move any more of the code under document.ready()

  • This code needs to be called on document.ready() for each page, after each load
  • Few of the functions that could be called from within document.ready() up are similar betweeen metadata_general.html and batch_annotate.html
  • Clarity is lost if this code is moved away from the elements it works on

Some cross-referencing between dialogs etc has been fixed where necessary, by using different element ids. E.g. see http://github.com/will-moore/openmicroscopy/commit/0329b2000692ab5f0b7bca07771ac6357354b9b6

Closing...

comment:3 Changed 7 years ago by Will Moore <will@…>

(In [bb1424f4433e757bfcb2e05c60336de73742d122/ome.git] on branch develop) metadata_general.html and batch_annotate.html js cleanup. See #7794

comment:4 Changed 7 years ago by Will Moore <will@…>

(In [99a724fa71b5cc09cf7919af8a97032e41a49e3b/ome.git] on branch develop) Moving ex-iframe js up to containers.html See #7794 #7795

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.81700 sec.)

We're Hiring!