Context Navigation

Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.

Changes between Version 1 and Version 2 of Ticket #7985

Timestamp:: 02/04/12 23:51:57 (12 years ago)
Author:: wmoore
Comment:

Legend:

: Unmodified
: Added
: Removed
: Modified

Ticket #7985 – Description

-                      v1
+                      v2
 you should use appropriate try/except statements.
 For more info on logging, see [link]
+For 500 errors, it is a good idea to always return the stack trace along with any message you want the user to see.
+This allows users to inspect or submit the error for diagnosis etc.
+This is only advised for trivial errors, where you can give the user a simple message, E.g."No Objects selected, Please try again".
+For server errors, it is usually best to allow the exception to be handled by Django since this will provide a lot more info to the user (request details etc)
+and format html etc (both with Debug True or False).
+If you still want to handle the exception yourself, you can provide stack trace alongside a message for the user.
 {{{
 try:
 …
     logger.error(traceback.format_exc())                                    # log the stack trace
     err_msg = "Something bad happened! \n \n%s" % traceback.format_exc()    # message AND stack trace
+    return HttpResponseServerError(err_msg)
+    if request.is_ajax():
+        return HttpResponseServerError(err_msg)
+    else:
+        ...   # render err_msg with a custom template
+        return HttpResponseServerError(content)
 }}}
+An alternative is to raise the exception with your custom message, allowing Django to handle it:
+{{{
+except Exception, x:
+    logger.error(traceback.format_exc())                                    # log the stack trace
+    err_msg = "Something bad happened! \n \n%s" % traceback.format_exc()
+    raise x.__class__(err_msg)
+}}}
+However, the stack trace of the Exception will originate from your raise statement, even though the message of the exception
+contains your original stack trace.