Task #8146 (closed)
Opened 7 years ago
Closed 7 years ago
LEI: 'PositionZ' & 'ExposureTime' in <Plane>
| Reported by: | wmoore | Owned by: | wmoore |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-4.4 |
| Component: | Bio-Formats | Version: | n.a. |
| Keywords: | n.a. | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description (last modified by wmoore)
I may be missing something but I can't see where this is being populated from at the moment.
It seems that it is the same value for all planes in an image, even if the image is a Z stack.
Propose that we should not populate "PositionZ".
See commit: https://github.com/will-moore/openmicroscopy/commit/539b00878e5bbe7d352d1fb805ce7f5c16484300
Change History (6)
comment:1 Changed 7 years ago by wmoore
- Description modified (diff)
comment:2 Changed 7 years ago by mlinkert
comment:3 Changed 7 years ago by wmoore
Sounds great!
Sorry for the delayed response - missed your comment in passing.
Cheers.
comment:4 Changed 7 years ago by wmoore
- Summary changed from LEI: 'PositionZ' in <Plane> to LEI: 'PositionZ' & 'ExposureTime' in <Plane>
I also noticed that for Martin's "sample files.lei", every <Plane> is getting
ExposureTime="0.0"
I'm not sure this is being read from anywhere or if it's genuine info, but if not, could we also omit writing this value?
Cheers.
comment:5 Changed 7 years ago by mlinkert
- Owner changed from mlinkert-x to wmoore
ExposureTime? should be fixed with https://github.com/melissalinkert/bioformats/commit/62eac0857ec8e63693e33d38854c227a5eb2f3eb
Plane.PositionZ should be fixed with https://github.com/melissalinkert/bioformats/commit/2ae515c8cad81be8fa5c09970424751ebffe8091
comment:6 Changed 7 years ago by wmoore
- Resolution set to fixed
- Status changed from new to closed
All looks good. Closing...
Seems fine. The Plane.PositionZ is being populated in two places, both of which explicitly set every plane to have the same value:
Certainly makes sense to not populate it, but then I'd propose that we populate StageLabel?.Z with the same information instead (so that it is still preserved somehow). What do you think?