Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #8192 (closed)

Opened 7 years ago

Closed 4 years ago

Stylesheets and test

Reported by: jburel Owned by: ajpatterson
Priority: major Milestone: 5.1.0
Component: General Version: 5.0.8
Keywords: n.a. Cc: jburel
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

Add tests for each entry in the downgrade catalogs.

Change History (10)

comment:1 Changed 7 years ago by jburel

  • Milestone changed from OMERO-Beta4.4 to OMERO-Beta4.4.1

Some tests have been written already, add more as part of 4.4.x series.

comment:2 Changed 7 years ago by ajpatterson

  • Milestone changed from OMERO-Beta4.4.1 to Future

comment:3 Changed 7 years ago by ajpatterson

It might be possible to also generate legacy samples from the same code using downgrades, each sample is not that complex but the test code necessary is quite verbose, legacy samples made this way would also not contain tests of old structures with no current equivalent

comment:4 Changed 7 years ago by jmoore

For OMERO.tables, Simon created a gist using an older library to generate a test file which has old structures (keeping that explanation vague to show the parallel; see https://gist.github.com/4261679). It might be that we have to do something like this outside of the regular workflow. Obviously, having good test data is more critical than the complexity of the code, and I would argue we need the old structures.

comment:5 Changed 7 years ago by jburel

Useful to have them as gist but yet another place to look at and very easy to miss/forget. It will be useful to have them somehow under openmicroscopy.

Last edited 7 years ago by jburel (previous) (diff)

comment:6 Changed 7 years ago by ajpatterson

So the idea would be to have the test shell out to run a command to make an old test file using a pre compiled jar? Then add a collection of old jars to git for the tests to use.

comment:7 Changed 7 years ago by jmoore

jburel: yup, gists are not optimal. Do we need a repository per version?

ajpatterson: that would work except then we would have to have the old jars present to, which I worry about due to size.

comment:8 Changed 7 years ago by ajpatterson

Referencing ticket #9085 has changed sprint.

comment:9 Changed 7 years ago by ajpatterson

  • Milestone changed from Future to OMERO-5

comment:10 Changed 4 years ago by jburel

  • Milestone changed from 5.x to 5.1.0
  • Resolution set to fixed
  • Status changed from new to closed
  • Version set to 5.0.8
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.95049 sec.)

We're Hiring!