Task #83 (closed)
Propagate Filter.isUnique() usage to all Queries.
| Reported by: | jamoore | Owned by: | jamoore |
|---|---|---|---|
| Priority: | minor | Milestone: | 3.0-M2 |
| Component: | Queries | Version: | 3.0-M1 |
| Keywords: | iteration3, final | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
Currently only StringQuery? (as of r661) uses the Filter.isUnique() value. All other Query subclasses should do the same.
This may need refactoring to take the control over this call out of their hands.
- Add doCall(Criteria) and doCall(Query) methods.
- Simple return the Criteria or Query from runQuery
- ...
Change History (3)
comment:1 Changed 18 years ago by jmoore
- Keywords iteration3 added
comment:2 Changed 18 years ago by jmoore
- Keywords final added
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 18 years ago by jmoore
r713 fixes a small mistake in Query where _criteria.list() was used twice rather than _criteria.uniqueResult().
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
Supported by r707. The solution chosen was to rename runQuery to buildQuery which must call either setCriteria or setQuery.
Also generally improved documentation, refactored some copy-n-paste actions, made some classes top-level (public) for testing, and lowered the visibility of some non-ome.* fields.
Didn't yet make the methods final, anyone have an opinion?
Closing.