Task #8314 (closed)
actions.js cleanup
| Reported by: | wmoore | Owned by: | wmoore |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-4.4 |
| Component: | Web | Version: | n.a. |
| Keywords: | n.a. | Cc: | atarkowska, cxallan |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | 2012-03-27 (11) |
Description
Most of this functionality has been replaced by listeners on the jsTree selection changes and can be removed.
Change History (7)
comment:1 Changed 7 years ago by wmoore
- Status changed from new to accepted
comment:2 Changed 7 years ago by wmoore
- Resolution set to fixed
- Status changed from accepted to closed
comment:3 Changed 7 years ago by Will Moore <will@…>
(In [43dba4f0a25465c8c478728ab7379cda1d5a1a46/ome.git] on branch develop) Removed loadOtherPanels(). 'deselect' listeners. See #8314
In all the places where we have selection listeners on jstree, we also listen for deselect
events, since we always need to know about change in selection.
This removes the last usage of loadOtherPanels() and syncPanels() in actions.js and
these have been removed.
comment:4 Changed 7 years ago by Will Moore <will@…>
(In [e21121c7cdddd6fcde5f7e1d74cb145be491a4b5/ome.git] on branch develop) Removing refreshCenterPanel() from actions.js See #8314
This was mostly being called after tree rearrangements or refresh, but is not needed
as updating of center (and right-hand) panels happens automatically on selection
changes in tree.
comment:5 Changed 7 years ago by Will Moore <will@…>
(In [7fec03ab36d1e3067343daaf249f9fb9a528b75b/ome.git] on branch develop) Removing unused changeView() from actions.js See #8314
comment:6 Changed 7 years ago by Will Moore <will@…>
(In [0260d48c1bfc50ba85f13e5467cbabc2a4d30315/ome.git] on branch develop) createDiscussion via dialog. loadMetadataPanel() removed!
This completes the actions.js cleanup - See #8314
comment:7 Changed 7 years ago by Will Moore <will@…>
(In [d23b8c95b0c844168d2d3742965c8902e51b0903/ome.git] on branch develop) createDiscussion via dialog. loadMetadataPanel() removed!
This completes the actions.js cleanup - See #8314
This commit and several before it complete the actions.js cleanup. https://github.com/will-moore/openmicroscopy/commit/728c7b1dbe3e6310dce1c0ab4cf96d42a7e5e019 on https://github.com/will-moore/openmicroscopy/tree/7339_tabs