Make_Movie Intro etc

[wmoore]

Make_Movie script needs functionality to:

• Add watermark to all frames (overlay png)
• Add Intro, of specified duration (use png)
• Add Outro, of specified duration (use png)

These 3 can all be specified using "Original File" parameters, where the original file is a png.

NB: If we expose these options in the Insight / Web UIs, we will have to allow users to pick Original Files (or at least allow them to specify a File Annotation, since Original File IDs are not currently displayed in the clients)

[wmoore]

Fixed with commit ​https://github.com/will-moore/openmicroscopy/commit/c5a0f53da5951fb4381b5d3024837a2dcda21eda on branch ​https://github.com/will-moore/openmicroscopy/tree/movie_intro_8380.

TODO: use Original File Objects (not IDs) for Intro, Ending and Watermark parameters.

[wmoore]

Using server updates from ​https://github.com/joshmoore/openmicroscopy/tree/object-script-param I can now run script like this:

$ omero script launch 7852 Image_ID=4602 Watermark=OriginalFile:7701 Z_End=4 Intro_Slide=OriginalFile:7701

with this commit: ​https://github.com/will-moore/openmicroscopy/commit/e43ca0aad99959a238e6488f9019b6a280abeb92

Closing...

[wmoore]

Josh, Carlos - I discussed with Jean-Marie and we agreed that in 4.4 we didn't want to update the Insight Make_Movie UI to include these new parameters, BUT we could still include the updated script in 4.4 since these parameters are optional and the script should behave exactly the same as before.

So, does it make any difference to you Calos, whether the new script is included in 4.4 or in 4.4.1 (when we'll update Insight - #8392)

[cneves]

I will need the updated script to support movie making on JCB, thus the sooner the better. I can keep merging a branch if there's a strong reason not to include it in 4.4.

[jmoore]

Will: I'd vote for a PR as well once you're satisfied. If Carlos needs to make further modifications, you could review those to make sure they're inline with what you and Jean-Marie are thinking of for the UI.

[wmoore]

Josh, Carlos - Just chatted to JM about our discussion & plans to pass RenderingDef? ID to script, then move to passing a string encoding all the rendering settings..

JM didn't like the idea of passing a string and much prefered the option of a RenderingDef? Object. This need not be loaded (or even saved to DB) but could still be populated with all the settings you need. You should be able to use this even if you don't have permissions to save Rdef, but this also allows you to pass a loaded Rdef after saving.

Also, this approach protects us from changes in Rdefs, E.g. co-domain (reverse contrast), false-colour etc that we might support in the future.

[jmoore]

That's fine, but then we'll need to allow a method on RenderingEngine which allows getting and setting the current rdef which we previously prevented. The Python code should still be pushed down to the gateway so one could do this:

    # PSEUDO-CODE!
    # ==============
    conn = BlitzGateway()
    re = conn.createRenderingEngine()
    re.doStuff() # make changes
    rdef = re.getCurrentSettings()
    spec = conn.convertSettingsToString(rdef)
    # User views stuff
    rdef = conn.convertStringToSettings(spec)
    re.setCurrentSettings(rdef)
    ... render, etc.

[Will Moore <will@…>]

(In [c5a0f53da5951fb4381b5d3024837a2dcda21eda/ome.git] on branch develop) Adding Intro, Watermark etc to Make_Movie. Closes #8380

This uses Original File IDs to specify intro, ending slides and watermark. Also adds
parameters for Intro_Duration and Ending Duration.