Task #8387 (closed)
Review webclient use of isEditable etc
| Reported by: | wmoore | Owned by: | wmoore |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-4.4 |
| Component: | Web | Version: | n.a. |
| Keywords: | n.a. | Cc: | atarkowska, cxallan, jamoore, jburel |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2012-04-10 (12) |
Description (last modified by wmoore)
Trying to assess the impact of permissions changes to judge if we have time to support these in the clients for 4.4 release.
All objects will have canEdit() and canAnnotate() (need to have Permissions loaded) see #8277. canEdit() includes Delete, renaming objects, linking P/D/I etc.
Document places in web where
- current functionality would switch to using these methods
- new checks made to allow more / fewer actions
isEditable
- metadata_general.html - Add tag, file, comment
- image viewer - reset & save rendering settings
isOwned
- Tree right-click actions (drag, delete etc) are set via isOwned in template "-locked". Same for P/D/I and Tags.
- Same flag is used to set disabled state of toolbar buttons
- metadata_general.html - Edit name, description
- link.isOwned used to allow removal of Tags, Files
- Basket items & table center panel indicate if not isOwned
- Image viewer - if isOwned include resetDefaults()
- Several places the name of the Owner is displayed if NOT owned. E.g. metadata_general,
- Links to Tags also add ?experimenter=eid if not Owned
canDelete
- ann.canDelete to remove Comments...
Change History (7)
comment:1 Changed 12 years ago by wmoore
- Description modified (diff)
comment:2 Changed 12 years ago by wmoore
- Description modified (diff)
comment:3 Changed 12 years ago by jburel
- Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)
comment:4 Changed 12 years ago by wmoore
- Remaining Time changed from 0.5 to 0
- Resolution set to fixed
- Status changed from new to closed
This is not an exhaustive list of group / editing permissions in web, but it this overview gives the impression that it would not be too much work to turn on/off the various editing options (Edit, Delete, P/D/I links, Annotate, Render settings etc) based on any object's canEdit() and canAnnotate() methods.
As disussed in today's OME meeting (no Carlos Chris or Jason) we're still not sure whether to try and get these group permissions into the server for 4.4 release.
Closing...
comment:5 Changed 12 years ago by Will Moore <will@…>
(In [f747b88403054662f2c803ef20c81ee3aff3bfbd/ome.git] on branch develop) Web use link.canDelete for Tags and FileAnns?. See #8387
comment:6 Changed 12 years ago by Will Moore <will@…>
(In [e92dbe3c5933a8427b4d9e7991fc4ee94eefdcf6/ome.git] on branch develop) Web canEdit instead of isOwned for '-locked' on trees, icons etc. See #8387
comment:7 Changed 12 years ago by Will Moore <will@…>
(In [e7c195c10f448c751b133d6225a166519c6fa74a/ome.git] on branch develop) Web always show Owner, (remove isOwned check) on icons etc. See #8387
Moved from sprint 2012-03-27 (11)