Task #8400 (closed)
Bug: Multi-line description display
| Reported by: | wmoore | Owned by: | atarkowska |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-4.4 |
| Component: | Web | Version: | n.a. |
| Keywords: | n.a. | Cc: | dgaudioso, saloynton |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2012-04-10 (12) |
Description (last modified by wmoore)
We don't use |linebreaks to display description in the right hand panel. If I add this, it breaks the edit-inline plugin.
This is kinda minor - I already started tidying the html since I found it tricky to understand and I wanted to link the commit to a ticket... See https://github.com/will-moore/openmicroscopy/commit/75a52496907021e8584e6b6366a5b5fca10bafa8
Change History (12)
comment:1 Changed 7 years ago by wmoore
- Description modified (diff)
comment:2 Changed 7 years ago by atarkowska
- Status changed from new to accepted
comment:3 Changed 7 years ago by atarkowska
- Remaining Time set to 0.2
comment:4 Changed 7 years ago by atarkowska
- Remaining Time changed from 0.2 to 0
- Resolution set to fixed
- Status changed from accepted to closed
comment:5 Changed 7 years ago by atarkowska
- Resolution fixed deleted
- Status changed from closed to reopened
comment:6 Changed 7 years ago by atarkowska
- Remaining Time changed from 0 to 0.3
comment:7 Changed 7 years ago by atarkowska
For edit in place plugin we cant use linebreaks as replaces line breaks in plain text with either a single newline becomes (<br />) and a new line followed by a blank line becomes a paragraph break (</p>). Paragraph break mess in html code and put description outside the description identifier. Instead of we have to use linebreaksbr as that one converts all newlines in a piece of plain text to (<br />) only.
comment:8 Changed 7 years ago by atarkowska
- Remaining Time changed from 0.3 to 0
- Status changed from reopened to closed
comment:9 Changed 7 years ago by Aleksandra Tarkowska <A.Tarkowska@…>
- Resolution set to fixed
(In [d897a8ec316f29187956f3cb7b78f0ba82451f23/ome.git] on branch develop) adding multi line break to the the description, close #8400
comment:10 Changed 7 years ago by Aleksandra Tarkowska <A.Tarkowska@…>
(In [f4ec97c2da9958693c831c12155778bb7f7302a2/ome.git] on branch develop) replacing linebreaks by linebreaksbr, see #8400
comment:11 Changed 7 years ago by Aleksandra Tarkowska <A.Tarkowska@…>
(In [5eac72c248d2ccc39e621c7e48c2298f3c7a0c39/ome.git] on branch develop) Cleaning up html for right-hand panel description. See #8400
Conflicts:
components/tools/OmeroWeb/omeroweb/webclient/templates/webclient/annotations/metadata_general.html
comment:12 Changed 7 years ago by Will Moore <will@…>
(In [f8054f1af6e741fb7fdf4aac64b6295eb57e623e/ome.git] on branch develop) Consistently use |linebreaksbr for all descriptions. See #8400
Pushed to https://github.com/aleksandra-tarkowska/openmicroscopy/tree/sprint12-web-backlog