Bug: @login_required & @jsonp

[wmoore]

Many places in webgateway/views.py we want to use the login_required and jsonp decorators at the same time.

E.g.

@jsonp
@login_required()
def imageData_json (request, conn=None, _internal=False, **kwargs):

This fails when we have no connection since @login_required() returns something that is not JSON compatible. E.g:

TypeError: <django.http.HttpResponseRedirect object at 0x103da5590> is not JSON serializable

Seems to make more sense to switch the order of the decorators like this:

@login_required()
@jsonp
def imageData_json (request, conn=None, _internal=False, **kwargs):

Now we get a different problem since the @jsonp decorator returns a string or dict instead of an HttpResponse?, due to these lines in jsonp:

    conn = kwargs.get('conn', None)
...
    if conn is not None or kwargs.get('_internal', False):
        return rv
    return HttpResponse(rv, mimetype='application/javascript')

Not sure what the logic is here Carlos?
Do you need a different response when not connected?

[wmoore]

In Commit ​https://github.com/aleksandra-tarkowska/openmicroscopy/commit/5e5d630d90eac8309ae62b0c69543ec5d1371101

jsonp decorator handles any HttpResponse? it recieves by simply returning it directly.

Therefore, @jsonp remains as the outer decorator when used with @login_required.

Closing...

[Will Moore <will@…>]

(In [5e5d630d90eac8309ae62b0c69543ec5d1371101/ome.git] on branch develop) Fixing @jsonp handling ResponseRedirect? from @login_required. Close #8410

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [40b327959e325ecfb6dd7491bf213eb1c9b4883f/ome.git] on branch develop) Fixing @jsonp handling ResponseRedirect? from @login_required. Close #8410