Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #8580 (closed)

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

Bug: Calendar events vv center panel

Reported by: wmoore Owned by: atarkowska
Priority: major Milestone: OMERO-4.4
Component: Services Version: n.a.
Keywords: n.a. Cc: atarkowska, cxallan
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-06-05 (16)

Description (last modified by wmoore)

Since timelineService.getEventLogsByPeriod() is used to populate the calendar in left-hand History panel, this includes events that are not from the current group. However, the center panel is populated with getCountByPeriod or getByPeriod which only show the current group data.

This is confusing since you click on a date in the calendar that has some events, but nothing is displayed in the center.

See screen-shot.

Attachments (1)

Screen shot 2012-04-19 at 11.01.44.png (60.9 KB) - added by wmoore 12 years ago.
18th is selected, but no data is shown

Download all attachments as: .zip

Change History (17)

comment:1 Changed 12 years ago by wmoore

comment:2 Changed 12 years ago by jmoore

I haven't taken a look at your test yet, Will, but will here shortly. Just from your description, though, I think this is more of a feature request. Setting omero.group is not intended to filter methods that currently return data from more than one group. Instead, it only changes your active group for the duration of the method call. I.e. if you had two gateway instances, each logged into different groups, and both called the ITimeline method above, they would get the same results. Setting omero.group should behave exactly the same.

However, if everyone who's using ITimeline would like the data to be filtered by current group, we can add that (time allowing) as an RFE.

comment:3 Changed 12 years ago by jmoore

The failure I get with your test, Will, is:

======================================================================
FAIL: testCreateHistory (__main__.HistoryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/gatewaytest/multi_group.py", line 88, in testCreateHistory
    self.searchHistory(start, end)
  File "test/gatewaytest/multi_group.py", line 53, in searchHistory
    self.assertEqual(dataCount, logCount)
AssertionError: 0 != 1

which says to me the real problem is that countByPeriod does not check for readability, while getByPeriod obviously has to.

comment:4 Changed 12 years ago by wmoore

No - countByPeriod and getByPeriod return the same numbers, it's getEventLogsByPeriod that returns more, since they're not filtered by group.

But you're right, this isn't an omero.group filtering bug, since the behavior is the same as switching active group proper - getEventLogsByPeriod() queries across groups regardless.

It's more of a webclient UI issue then, since we display more objects in the calendar (uses getEventLogsByPeriod) than we do in the center panel. I'll fix the test so it doesn't fail with this behavior - then we'll decide what to do in the UI.

Changed 12 years ago by wmoore

18th is selected, but no data is shown

comment:5 Changed 12 years ago by wmoore

  • Description modified (diff)
  • Owner changed from jmoore to atarkowska
  • Summary changed from Bug: getEventLogsByPeriod with omero.group to Bug: Calendar events vv center panel

comment:6 Changed 12 years ago by atarkowska

  • Owner atarkowska deleted

comment:7 Changed 12 years ago by atarkowska

  • Owner set to atarkowska

In order to fix ITimeline we need to add add something like "x.details.group.id = :current_group" to all the queries (except for when current_group = −1)

comment:8 Changed 12 years ago by atarkowska

  • Sprint changed from 2012-04-24 (13) to 2012-05-08 (14)

comment:9 Changed 12 years ago by jburel

  • Sprint changed from 2012-05-08 (14) to 2012-05-22 (15)

Moved from sprint 2012-05-08 (14)

comment:10 Changed 12 years ago by Will Moore <will@…>

(In [dde1672365706d8a886d24df70b591ffc06f72c4/ome.git] on branch develop) gatewaytest for getEventLogsByPeriod(). See #8580

comment:11 Changed 12 years ago by jburel

  • Sprint changed from 2012-05-22 (15) to 2012-06-05 (16)

Moved from sprint 2012-05-22 (15)

comment:12 Changed 12 years ago by atarkowska

  • Status changed from new to accepted

comment:13 Changed 12 years ago by atarkowska

  • Remaining Time set to 1

comment:14 Changed 12 years ago by atarkowska

  • Remaining Time changed from 1 to 0
  • Status changed from accepted to closed

comment:15 Changed 12 years ago by Aleksandra Tarkowska <A.Tarkowska@…>

(In [5d2ef76584800376b7b29fab845f3c0c64455d4f/ome.git] on branch develop) fixing group filter, see #8580

comment:16 Changed 12 years ago by Aleksandra Tarkowska <A.Tarkowska@…>

  • Resolution set to fixed

(In [872d5df31c4e1801ae7ec66064fd09c561205e16/ome.git] on branch develop) fixing calendar entries by resolving group id in current context, close #8580

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.67743 sec.)

We're Hiring!