Bug: Calendar events vv center panel

[wmoore]

Since timelineService.getEventLogsByPeriod() is used to populate the calendar in left-hand History panel, this includes events that are not from the current group. However, the center panel is populated with getCountByPeriod or getByPeriod which only show the current group data.

This is confusing since you click on a date in the calendar that has some events, but nothing is displayed in the center.

See screen-shot.

[wmoore]

Failing gatewaytest ​https://github.com/will-moore/openmicroscopy/commit/dde1672365706d8a886d24df70b591ffc06f72c4
on branch ​https://github.com/will-moore/openmicroscopy/commits/group_switch_8102

getEventLogsByPeriod() returns events that are not filtered by omero.group.

[jmoore]

I haven't taken a look at your test yet, Will, but will here shortly. Just from your description, though, I think this is more of a feature request. Setting omero.group is not intended to filter methods that currently return data from more than one group. Instead, it only changes your active group for the duration of the method call. I.e. if you had two gateway instances, each logged into different groups, and both called the ITimeline method above, they would get the same results. Setting omero.group should behave exactly the same.

However, if everyone who's using ITimeline would like the data to be filtered by current group, we can add that (time allowing) as an RFE.

[jmoore]

The failure I get with your test, Will, is:

======================================================================
FAIL: testCreateHistory (__main__.HistoryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/gatewaytest/multi_group.py", line 88, in testCreateHistory
    self.searchHistory(start, end)
  File "test/gatewaytest/multi_group.py", line 53, in searchHistory
    self.assertEqual(dataCount, logCount)
AssertionError: 0 != 1

which says to me the real problem is that countByPeriod does not check for readability, while getByPeriod obviously has to.

[wmoore]

No - countByPeriod and getByPeriod return the same numbers, it's getEventLogsByPeriod that returns more, since they're not filtered by group.

But you're right, this isn't an omero.group filtering bug, since the behavior is the same as switching active group proper - getEventLogsByPeriod() queries across groups regardless.

It's more of a webclient UI issue then, since we display more objects in the calendar (uses getEventLogsByPeriod) than we do in the center panel. I'll fix the test so it doesn't fail with this behavior - then we'll decide what to do in the UI.

[wmoore]

18th is selected, but no data is shown