Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #8630 (closed)

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

Bug: new_user_group bean setting is broken

Reported by: jamoore Owned by: jamoore
Priority: critical Milestone: OMERO-4.4
Component: Security Version: n.a.
Keywords: n.a. Cc: harri.jaalinoja@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-05-08 (14)

Description

See: http://lists.openmicroscopy.org.uk/pipermail/ome-users/2012-March/002974.html

Issue found by Harri Jäälinoja in which the groups returned by a users' own NewUserGroupBean were being ignored.

Hi Josh,
sorry, I had to escape quickly on Friday. Yes, all the code for the hyldap component is on github. Below is the change I made in OMERO code, I didn't try to commit it, I don't think I have access, and anyway I don't feel confident with git yet, so I thought it is best I just report it via email:

[omero@lmu-omero3 OMERO]$ diff develop/openmicroscopy/components/server/src/ome/logic/LdapImpl.java joshmoore/openmicroscopy/components/server/src/ome/logic/LdapImpl.java
476c476
< bean.groups(username, config, ldap, provider, attrSet);
---

groups.addAll(bean.groups(username, config, ldap, provider, attrSet));

I think we are fine at the moment, this proves that LDAP-authentication works and it is also possible to get the group names. So if you can just make sure that the fix is included in the next release, and I will test it again at that point.

Cheers,
Harri

Change History (2)

comment:1 Changed 10 years ago by jmoore

  • Cc harri.jaalinoja@… added
  • Remaining Time changed from 0.1 to 0
  • Resolution set to fixed
  • Status changed from new to closed

Pushed to my sprint14 branch.

comment:2 Changed 10 years ago by jmoore

See also Harri's bean work: https://gist.github.com/2172934

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.63361 sec.)

We're Hiring!