Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #8648 (closed)

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

Tree select sync from center panel

Reported by: wmoore Owned by: wmoore
Priority: major Milestone: OMERO-4.4
Component: Web Version: n.a.
Keywords: n.a. Cc: atarkowska, cxallan
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: 2012-05-08 (14)

Description

Two main problems to address:

  • Middle panel can be refreshed and get out of sync with tree (E.g. if import is happending elsewhere). This causes selection sync events, especially since thumbnails select tree by index not ID.
  • Thumbs, Table etc center panels have a load of code duplicated to update the tree on selection change.

Solution:

  • Move the tree selection logic to a single place, using IDs of the thumbs / table row to update the tree. This will make it easier for center plugin developers to update tree. If the object is not found in the tree, the tree should refresh.

Change History (4)

comment:1 Changed 7 years ago by wmoore

NB: Check why tree selection is not working from center panel in container_tags.html

comment:2 Changed 7 years ago by wmoore

  • Status changed from new to accepted

comment:3 Changed 7 years ago by wmoore

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed with commit https://github.com/aleksandra-tarkowska/openmicroscopy/commit/0a645f80b4452f461ca1ce9dfed07a6203796351

Thumbs use image-ids to select tree. If image not in tree, refresh the dataset.

Closing...

comment:4 Changed 7 years ago by Will Moore <will@…>

(In [0a645f80b4452f461ca1ce9dfed07a6203796351/ome.git] on branch develop) Thumbs select tree by image-id. Refresh if not found. See #8648

I haven't moved all the selection logic to a single place (for the icons and table pages to use the same logic)
since table has it's own logic for choosing multi-select, range etc. It can't use the tree logic for this
since the table may be in a different order from the tree.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.85878 sec.)

We're Hiring!