Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #8692 (closed)

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

Bug: Unexpected search results

Reported by: wmoore Owned by: jamoore
Priority: blocker Milestone: OMERO-4.4
Component: Services Version: n.a.
Keywords: n.a. Cc: rkferguson, atarkowska, dgaudioso, saloynton, jburel
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-06-05 (16)

Description

From Gus (testing webclient search):

  • Search for 'ome' returns imgaes that have no 'ome' text.
  • Search for 'centrosomes' does not find images that have this in their name.
  • Often repeating a search returns different results each time.

I'll see if I can reproduce some of this, then hand over to someone else!

Attachments (2)

Not finding in all groups.png (1.1 MB) - added by rkferguson 12 years ago.
Not finding search term in title.png (954.0 KB) - added by rkferguson 12 years ago.

Change History (21)

comment:1 Changed 12 years ago by jburel

  • Sprint changed from 2012-05-08 (14) to 2012-05-22 (15)

Moved from sprint 2012-05-08 (14)

comment:2 Changed 12 years ago by wmoore

  • Owner changed from wmoore to jmoore

I have found similar unexpected search results. E.g. import 50 images named "emd_1000.map", "emd_1001.map" etc.
Do a search and it only finds a subset of these images.

comment:3 Changed 12 years ago by jmoore

  • Remaining Time set to 0.5
  • Status changed from new to accepted

Doesn't look like the values are even getting saved to FullText?. Not sure what's going on.

comment:4 Changed 12 years ago by jmoore

  • Priority changed from major to blocker
  • Remaining Time changed from 0.5 to 1.0
  • Sprint changed from 2012-05-22 (15) to 2012-06-05 (16)

After initial investigation, it looks like no values are being store in /OMERO/FullText whatsoever. This will take more research just to figure out what's happened. Pushing to the next sprint.

comment:5 Changed 12 years ago by saloynton

Josh is this a related issue?

It seems like the date is ignored in searches. Get the same search results regardless of whether the date field is populated or which date is picked.
Taken from the two problems in ticket #8679. This seems like a higher priority.

comment:6 Changed 12 years ago by jmoore

Scott: this issue will block all other search testing.

comment:7 Changed 12 years ago by jmoore

Two commits are involved here:

59ddcbd - OmeroSearch : temporary fix post-JTA and relevance. (3 years, 5 months ago) <jmoore>
e17e85f - Post-hibernate upgrade search config improvements (4 months ago) <jmoore>

A FIXME was added 3 years ago when worker.batch_size was set to 1. With a Hibernate update, I thought it could be removed, but apparently it can't (at least not for use with the IUpdate.indexObject method). Turning the batch_size back down so low will again have negative performance impacts, but there may not be a way around it for the moment.

comment:8 Changed 12 years ago by jmoore

  • Cc saloynton jburel added
  • Component changed from Web to Services
  • Remaining Time changed from 1.0 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed

Search should be fixed now (or back to its regular state at least). Commits pushed to sprint16-bugfixes:

6a6c0b3 - (HEAD, origin/sprint16-bugfixes, sprint16-bugfixes) Fix typo in search.py plugin (3 minutes ago) <jmoore>
dcbe3f8 - Fix startup error in background processes (3 minutes ago) <jmoore>
0d21613 - Revert to the batch_size=1 FIXME (Fix #8692) (3 minutes ago) <jmoore>

comment:9 Changed 12 years ago by rkferguson

  • Resolution fixed deleted
  • Status changed from closed to reopened

Still problems with search results:

Insight:

User-6 read-only-1. Insight - searched for copy-and-paste word from description "centrosome". Found it in 9 private-1 group images but not in any read-only-1 images - definitely there in more than one image (counted at least 5) - see screenshot. Reproduced for another definite positive search term in the name field - also returned 9 results for private-1 but none for read-only-1.

Web:

User-6 read-only. Not finding search term "kinetochores" in title of images when it is in a number of them. When serching in private-1 seems to be finding images in read-only-1 as well as private-1.

Changed 12 years ago by rkferguson

Changed 12 years ago by rkferguson

comment:10 Changed 12 years ago by jburel

  • Owner changed from jmoore to jburel
  • Status changed from reopened to accepted

comment:11 Changed 12 years ago by jburel

The arguments specified for the search services are the same but results are only returned in the context of the private group.

comment:12 Changed 12 years ago by jburel

I am not able to check in web since it is not possible to search terms in description

comment:13 Changed 12 years ago by jburel

  • Owner changed from jburel to jmoore

Passing it back to Josh. No results returned for non-private groups.

comment:14 Changed 12 years ago by jmoore

  • Remaining Time changed from 0 to 0.25

Added and pushed a passing test, J-M. Let's discuss when you're available:

commit bd102f75b183ec32d096ca132f38966904eb9d32
Author: jmoore <josh@glencoesoftware.com>
Date:   Tue Jun 5 08:49:16 2012

    Passing test of search as group and system admin (See #8692)

comment:15 Changed 12 years ago by wmoore

Is this just a case of search by default using your "default group"? or just getting the wrong eventContext?

comment:16 Changed 12 years ago by jmoore

If omero.group is not getting passed, then currently you won't find anything that's not in your current group, if that's what you mean.

comment:17 Changed 12 years ago by jmoore

(duplicate post)

Last edited 12 years ago by jmoore (previous) (diff)

comment:18 Changed 12 years ago by jmoore <josh@…>

  • Remaining Time changed from 0.25 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed

(In [0d21613e599a5dbb058c31d8c0d87870a04698fa/ome.git] on branch develop) Revert to the batch_size=1 FIXME (Fix #8692)

comment:19 Changed 12 years ago by jmoore <josh@…>

(In [bd102f75b183ec32d096ca132f38966904eb9d32/ome.git] on branch develop) Passing test of search as group and system admin (See #8692)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.75091 sec.)

We're Hiring!