Task #8693 (closed)
Bug: Form_users.is_valid()
Reported by: | wmoore | Owned by: | wmoore |
---|---|---|---|
Priority: | critical | Milestone: | OMERO-4.4 |
Component: | Web | Version: | n.a. |
Keywords: | n.a. | Cc: | rkferguson, atarkowska |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | 0.0d |
Sprint: | 2012-05-08 (14) |
Description
Need to look at how this is being passed to the url in Group / Users dropdown, as well as ensuring that we handle it in the views.py or forms code.
Traceback (most recent call last): File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/django/core/handlers/base.py", line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/omeroweb/decorators.py", line 313, in wrapped retval = f(request, *args, **kwargs) File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/omeroweb/decorators.py", line 347, in wrapper context = f(request, *args, **kwargs) File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/omeroweb/webclient/views.py", line 368, in load_template if not form_users.is_valid(): Notes 12-05-02 - 02/05/2012 17:10 / 13 File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/django/forms/forms.py", line 121, in is_valid return self.is_bound and not bool(self.errors) File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/django/forms/forms.py", line 112, in _get_errors self.full_clean() File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/django/forms/forms.py", line 267, in full_clean self._clean_fields() File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/django/forms/forms.py", line 284, in _clean_fields value = field.clean(value) File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/django/forms/fields.py", line 163, in clean value = self.to_python(value) File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/omeroweb/webadmin/custom_forms.py", line 331, in to_python if checkValue(qq, value): File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/ python/omeroweb/webadmin/custom_forms.py", line 323, in checkValue if long(value) == q.id: ValueError: invalid literal for long() with base 10: '4?Acquisition=1101' <WSGIRequest GET:<QueryDict: {u'experimenter': [u'4?Acquisition=1101']}>, POST:<QueryDict: {}>, COOKIES:{'sessionid': '91dcc02e17983a68ce4aa9ce9e535c5c'}, META:{'DOCUMENT_ROOT': '/var/www', 'GATEWAY_INTERFACE': 'CGI/1.1', 'HTTP_ACCEPT': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/ *;q=0.8', 'HTTP_ACCEPT_ENCODING': 'gzip, deflate', 'HTTP_ACCEPT_LANGUAGE': 'en-us', 'HTTP_CONNECTION': 'keep-alive', 'HTTP_COOKIE': 'sessionid=91dcc02e17983a68ce4aa9ce9e535c5c', 'HTTP_HOST': 'gretzky.openmicroscopy.org.uk', 'HTTP_REFERER': 'http://gretzky.openmicroscopy.org.uk/webclient/ userdata/?experimenter=1553', Notes 12-05-02 - 02/05/2012 17:10 / 14 'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/534.55.3 (KHTML, like Gecko) Version/5.1.5 Safari/534.55.3', 'PATH': '/usr/local/bin:/usr/bin:/bin', 'PATH_INFO': u'/webclient/userdata/', 'PATH_TRANSLATED': '/home/omero/OMERO-CURRENT/var/omero.fcgi/ webclient/userdata/', 'QUERY_STRING': 'experimenter=4?Acquisition=1101', 'REMOTE_ADDR': '10.34.1.133', 'REMOTE_PORT': '59044', 'REQUEST_METHOD': 'GET', 'REQUEST_URI': '/webclient/userdata/?experimenter=4?Acquisition=1101', 'SCRIPT_FILENAME': '/home/omero/OMERO-CURRENT/var/omero.fcgi', 'SCRIPT_NAME': u'', 'SERVER_ADDR': '134.36.65.227', 'SERVER_ADMIN': 'webmaster@localhost', 'SERVER_NAME': 'gretzky.openmicroscopy.org.uk', 'SERVER_PORT': '80', 'SERVER_PROTOCOL': 'HTTP/1.1', 'SERVER_SIGNATURE': '<address>Apache/2.2.14 (Ubuntu) Server at gretzky.openmicroscopy.org.uk Port 80</address>\n', 'SERVER_SOFTWARE': 'Apache/2.2.14 (Ubuntu)', 'wsgi.errors': <flup.server.fcgi_base.TeeOutputStream object at 0x2f67d10>, 'wsgi.input': <flup.server.fcgi_base.InputStream object at 0x2c78ad0>, 'wsgi.multiprocess': True, 'wsgi.multithread': False, 'wsgi.run_once': False, 'wsgi.url_scheme': 'http', 'wsgi.version': (1, 0)}>
Change History (3)
comment:1 Changed 12 years ago by wmoore
- Status changed from new to accepted
comment:2 Changed 12 years ago by wmoore
- Resolution set to fixed
- Status changed from accepted to closed
comment:3 Changed 12 years ago by Will Moore <will@…>
- Remaining Time set to 0
(In [cd817262e506788bd2d68f409da9db971f1884b9/ome.git] on branch develop) Check experimenter Id before UsersForm?.is_valid. Closes #8693
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
Fixed with https://github.com/aleksandra-tarkowska/openmicroscopy/commit/cd817262e506788bd2d68f409da9db971f1884b9