Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #8695 (closed)

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

Group perms icons

Reported by: wmoore Owned by: atarkowska
Priority: major Milestone: OMERO-4.4
Component: Web Version: n.a.
Keywords: n.a. Cc: jburel, rkferguson, atarkowska
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-07-03 (18)

Description

With the new web UI and change in the permissions levels that OMERO supports, it seems like we need to consider what icons we use to indicate different permissions.

Goal is to minimise impact on users when we change permissions levels etc.

I'm assuming that we're going to allow "Read-Edit" group creation in the not-too-distant future (possibly 4.4.1)?

Currently, new web UI uses

  • Private: Red group icon
  • Read-Only: Orange group icon
  • Read-Write (will become read-Ann): Green icon

This leaves nothing for Read-Edit group, and it is also different from what Insight does.

One suggestion (in discussion with Dom)

  • Private: Black - single user icon
  • Read-Only: Red group icon
  • Read-Ann: Orange group icon
  • Read-Edit (4.4.1?): Green group icon

When we get to "World" permissions then this will be a different icon type, not just colour changes.

This is more similar to what Insight currently does, but it would still require some changes to Insight's group icons.

Discussion needed!

Change History (20)

comment:1 Changed 10 years ago by jburel

As previously mentioned, using these icons directly in insight will "break" the UI considering that we are mainly using the nuvola icon set.
We need to "transform" an existing nuvola icon to match the list described below.

Last edited 10 years ago by jburel (previous) (diff)

comment:2 Changed 10 years ago by dgaudioso

I'd be happy to adjust the nuvola icon set to roughly match what we have in the web client.

comment:3 Changed 10 years ago by jburel

  • Sprint changed from 2012-05-08 (14) to 2012-05-22 (15)

Moved from sprint 2012-05-08 (14)

comment:4 Changed 10 years ago by jburel

  • Sprint changed from 2012-05-22 (15) to 2012-06-05 (16)

Moved from sprint 2012-05-22 (15)

comment:5 Changed 10 years ago by jburel

  • Cc dgaudioso removed
  • Owner changed from jburel to saloynton

Scott to follow up with Liza

comment:6 Changed 10 years ago by jburel

  • Sprint changed from 2012-06-05 (16) to 2012-06-19 (17)

Moved from sprint 2012-06-05 (16)

comment:7 Changed 10 years ago by saloynton

Update: The first set from Liza should be ready towards the end of the week.

comment:8 Changed 10 years ago by jburel

  • Cc atarkowska added

comment:9 Changed 10 years ago by jburel

when the color code is finalized, a new set will probably be required for Web.

comment:10 Changed 10 years ago by jburel

Today's build will have the updated read-annotate icon, only in size 16x16. If we are happy with that, let's use the color code for the web icon. Liza will create the icons.

comment:11 Changed 10 years ago by jburel

  • Owner changed from saloynton to atarkowska
  • no need to modify the icons currently used. They follow the same color code.
  • The following code needs to be modified, group_user_dropdown.html
    <img
       {% if grp.getDetails.getPermissions.isGroupAnnotate %} src="{% static "webclient/image/group_orange16.png" %}"
        {% else %}
        {% if grp.details.permissions.isGroupRead %} src="{% static "webclient/image/group_red16.png" %}"
          {% else %}
            src="{% static "webclient/image/personal16.png" %}"
        {% endif %}
    {% endif %} />
    
    

This will not correctly display the correct icon for a read-write group since in a read-write group, isGroupAnnotate always returns true.

Similar changes probably in web admin if group icons are used.

comment:12 Changed 10 years ago by wmoore

  • Priority changed from critical to major

Updated to display a green group icon for Read-Edit groups, in both the group-user chooser and the "Move Group..." dialog.

https://github.com/will-moore/openmicroscopy/commit/7c3c435d36f2744f8b1bd6bbbce70474528fcbb4

                        {% if grp.getDetails.getPermissions.isGroupWrite %} src="{% static 'webclient/image/group_green16.png' %}"
                        {% else %}
                            {% if grp.getDetails.getPermissions.isGroupAnnotate %} src="{% static "webclient/image/group_orange16.png" %}"
                            {% else %}
                                {% if grp.details.permissions.isGroupRead %} src="{% static "webclient/image/group_red16.png" %}"
                                {% else %}
                                    src="{% static "webclient/image/personal16.png" %}"
                                {% endif %}
                            {% endif %}
                        {% endif %} />

However, this code is not very nice - need to find a nicer solution:

  • We call getDetails() and getPermissions() many times - this is potentially expensive - see #8858
  • if / else block is already a mess, and will get worse (or won't work) if we have other group perms - E.g. world read AND group-annotate etc.
  • Maybe need to map group permission strings to icons E.g. icon is "rwra--icon.png"

comment:13 Changed 10 years ago by jburel

  • Component changed from Usability to Web

In Web, the icon in the tree representing the user is the icon used for the private group. This will need to be changed.

Last edited 10 years ago by jburel (previous) (diff)

comment:14 Changed 10 years ago by jburel

  • Sprint changed from 2012-06-19 (17) to 2012-07-03 (18)

Moved from sprint 2012-06-19 (17)

comment:15 Changed 10 years ago by atarkowska

  • Status changed from new to accepted

comment:16 Changed 10 years ago by atarkowska

  • Remaining Time set to 0.1

comment:17 Changed 10 years ago by atarkowska

  • Remaining Time changed from 0.1 to 0
  • Status changed from accepted to closed

comment:19 Changed 10 years ago by rkferguson

Retested - working in Win 7 - IE9, OSX - Safari - Firefox - Camino

comment:20 Changed 10 years ago by Aleksandra Tarkowska <A.Tarkowska@…>

  • Resolution set to fixed

(In [3970da1f745c33e0f8c71a9f97ab566515c6cce2/ome.git] on branch develop) replacing user icon in trees, close #8695

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.69406 sec.)

We're Hiring!