Group perms icons

[wmoore]

With the new web UI and change in the permissions levels that OMERO supports, it seems like we need to consider what icons we use to indicate different permissions.

Goal is to minimise impact on users when we change permissions levels etc.

I'm assuming that we're going to allow "Read-Edit" group creation in the not-too-distant future (possibly 4.4.1)?

Currently, new web UI uses

• Private: Red group icon
• Read-Only: Orange group icon
• Read-Write (will become read-Ann): Green icon

This leaves nothing for Read-Edit group, and it is also different from what Insight does.

One suggestion (in discussion with Dom)

• Private: Black - single user icon
• Read-Only: Red group icon
• Read-Ann: Orange group icon
• Read-Edit (4.4.1?): Green group icon

When we get to "World" permissions then this will be a different icon type, not just colour changes.

This is more similar to what Insight currently does, but it would still require some changes to Insight's group icons.

Discussion needed!

[jburel]

As previously mentioned, using these icons directly in insight will "break" the UI considering that we are mainly using the nuvola icon set.
We need to "transform" an existing nuvola icon to match the list described below.

[dgaudioso]

I'd be happy to adjust the nuvola icon set to roughly match what we have in the web client.

[jburel]

Moved from sprint 2012-05-08 (14)

[jburel]

Moved from sprint 2012-05-22 (15)

[jburel]

Scott to follow up with Liza

[jburel]

Moved from sprint 2012-06-05 (16)

[saloynton]

Update: The first set from Liza should be ready towards the end of the week.

[jburel]

when the color code is finalized, a new set will probably be required for Web.

[jburel]

Today's build will have the updated read-annotate icon, only in size 16x16. If we are happy with that, let's use the color code for the web icon. Liza will create the icons.

[jburel]

• no need to modify the icons currently used. They follow the same color code.
• The following code needs to be modified, group_user_dropdown.html

  <img
     {% if grp.getDetails.getPermissions.isGroupAnnotate %} src="{% static "webclient/image/group_orange16.png" %}"
      {% else %}
      {% if grp.details.permissions.isGroupRead %} src="{% static "webclient/image/group_red16.png" %}"
        {% else %}
          src="{% static "webclient/image/personal16.png" %}"
      {% endif %}
  {% endif %} />
  
  

This will not correctly display the correct icon for a read-write group since in a read-write group, isGroupAnnotate always returns true.

Similar changes probably in web admin if group icons are used.

[wmoore]

Updated to display a green group icon for Read-Edit groups, in both the group-user chooser and the "Move Group..." dialog.

​https://github.com/will-moore/openmicroscopy/commit/7c3c435d36f2744f8b1bd6bbbce70474528fcbb4

                        {% if grp.getDetails.getPermissions.isGroupWrite %} src="{% static 'webclient/image/group_green16.png' %}"
                        {% else %}
                            {% if grp.getDetails.getPermissions.isGroupAnnotate %} src="{% static "webclient/image/group_orange16.png" %}"
                            {% else %}
                                {% if grp.details.permissions.isGroupRead %} src="{% static "webclient/image/group_red16.png" %}"
                                {% else %}
                                    src="{% static "webclient/image/personal16.png" %}"
                                {% endif %}
                            {% endif %}
                        {% endif %} />

However, this code is not very nice - need to find a nicer solution:

• We call getDetails() and getPermissions() many times - this is potentially expensive - see #8858
• if / else block is already a mess, and will get worse (or won't work) if we have other group perms - E.g. world read AND group-annotate etc.
• Maybe need to map group permission strings to icons E.g. icon is "rwra--icon.png"

[jburel]

In Web, the icon in the tree representing the user is the icon used for the private group. This will need to be changed.

[jburel]

Moved from sprint 2012-06-19 (17)

[atarkowska]

replaced by ​https://github.com/aleksandra-tarkowska/openmicroscopy/blob/3970da1f745c33e0f8c71a9f97ab566515c6cce2/components/tools/OmeroWeb/omeroweb/webclient/static/webclient/image/icon_user.png

[rkferguson]

Retested - working in Win 7 - IE9, OSX - Safari - Firefox - Camino

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [3970da1f745c33e0f8c71a9f97ab566515c6cce2/ome.git] on branch develop) replacing user icon in trees, close #8695