Task #8722 (closed)
Opened 7 years ago
Closed 7 years ago
Bug: CombineImages script wrongly initialize emission wavelength
| Reported by: | sbesson | Owned by: | jamoore |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-4.4 |
| Component: | General | Version: | n.a. |
| Keywords: | n.a. | Cc: | jburel, wmoore |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | 2012-06-19 (17) |
Description
Tested using the latest develop and Insight.
Steps to reproduce the bug
- use an existing single channel image with no emission wavelength / import a tif file with no metadata
- run Combine Figures script on this image only: new image is succesfully created
- run the Matlab or the Python script
Below is my result for the Python script
sbesson:~ sebastien$ python testCombineImages.py Image 326 Emission wavelength: None Image 327 created from image Ids: [326L] Emission wavelength: 1
Change History (9)
comment:1 Changed 7 years ago by sbesson
comment:2 Changed 7 years ago by Will Moore <will@…>
- Resolution set to fixed
- Status changed from new to closed
(In [4076086328e7f077eef8146c4359c331081bced3/ome.git] on branch develop) Refresh jsTree updates centre & right panels. Fixes #8722
comment:3 Changed 7 years ago by wmoore
- Resolution fixed deleted
- Status changed from closed to reopened
Oooops - wrong ticket number in that commit caused this ticket to close. Re-opening...
comment:4 Changed 7 years ago by jmoore <josh@…>
(In [2b7829669f9df0d3c95f442c43d413fe526257ab/ome.git] on branch develop) Make non-group permissions transient (See #8722)
Now that permissions are updated on read, we need to
make sure that Hibernate completely ignores the permissions
on all non-group objects. Several commits were made to make
this work, but ultimately only the move to @Transient did
the right thing.
comment:5 Changed 7 years ago by jmoore
- Type changed from Bug to Task
We don't use the "Bug" type but just the "Bug:" prefix on "Tasks".
comment:6 Changed 7 years ago by jmoore
- Component set to General
- Milestone set to OMERO-Beta4.4
comment:7 Changed 7 years ago by jmoore
- Owner set to sbesson
- Status changed from reopened to accepted
comment:8 Changed 7 years ago by wmoore
- Owner changed from sbesson to jmoore
Josh - the new image is created with
pixelsService.createImage(sizeX, sizeY, sizeZ, sizeT, channelList, pixelsType, imageName, description)
Sebastien's point is that this new image shouldn't have emission wavelengths of 1. It should just be null, otherwise you can't tell whether this is a genuine value etc.
comment:9 Changed 7 years ago by jmoore
- Resolution set to fixed
- Sprint set to 2012-06-19 (17)
- Status changed from accepted to closed
Check. Removed all nullable fields (statsinfo, emissionwave, physicalsize x,y,z) and pushed to sprint17:
commit f36c22160ba5aa2296893a1db0a1dfa40d826249
Author: jmoore <josh@glencoesoftware.com>
Date: Fri Jun 8 15:16:48 2012
Remove nullable fields from synthetic image (Fix #8722)
Reproduced using OMERO.server 4.3.4 server and OMERO.insight 4.3.3