Bug: change password

[wmoore]

This is broken from the Edit Experimenter page

Request URL: http://localhost:8000/webadmin/change_password/4/

Django Version: 1.3.1
Python Version: 2.6.1
Installed Applications:
['django.contrib.staticfiles',
 'django.contrib.markup',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'omeroweb.feedback',
 'omeroweb.webadmin',
 'omeroweb.webclient',
 'omeroweb.webgateway',
 'omeroweb.webtest',
 'omeroweb.webredirect']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware')


Traceback:
File "/Users/will/Desktop/OMERO/dist/lib/python/django/core/handlers/base.py" in get_response
  111.                         response = callback(request, *callback_args, **callback_kwargs)
File "/Users/will/Desktop/OMERO/components/tools/OmeroWeb/omeroweb/../omeroweb/decorators.py" in wrapped
  313.             retval = f(request, *args, **kwargs)
File "/Users/will/Desktop/OMERO/components/tools/OmeroWeb/omeroweb/../omeroweb/decorators.py" in wrapper
  347.             context = f(request, *args, **kwargs)
File "/Users/will/Desktop/OMERO/components/tools/OmeroWeb/omeroweb/../omeroweb/webadmin/views.py" in manage_password
  456.     context = {'info':info, 'error':error, 'password_form':password_form, 'eid': eid}

Exception Type: UnboundLocalError at /webadmin/change_password/4/
Exception Value: local variable 'password_form' referenced before assignment

[atarkowska]

As discussed:

• experimenter form 'change password' button needs to behave the same way as on my account page
• webadmin.manage_password needs clean up as no longer render any template, just handle ajax call only

[wmoore]

Fixed on Ola's sprint15-bug-fixes branch: ​https://github.com/aleksandra-tarkowska/openmicroscopy/commit/48d8960f9146a1f05cec6b02b001a07db81ea571

Closing...

[Will Moore <will@…>]

(In [48d8960f9146a1f05cec6b02b001a07db81ea571/ome.git] on branch develop) Edit Experimenter change-password dialog. Closes #8725

Also tidied up the 'BACK' button at top of the page. Now 'Cancel'