Task #8732 (closed)
Opened 7 years ago
Closed 7 years ago
Invert test ordering
| Reported by: | mlinkert | Owned by: | mlinkert |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-4.4.4 |
| Component: | Bio-Formats | Version: | n.a. |
| Keywords: | n.a. | Cc: | rleigh |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
Right now, we iterate first over the list of files, then over the list of tests. It is likely more efficient to iterate over the list of tests first, and the list of files, so that we can re-use the reader state for all but the first test for each file.
Change History (5)
comment:1 Changed 7 years ago by rleigh
comment:2 Changed 7 years ago by mlinkert
- Milestone changed from Unscheduled to OMERO-4.4.1
comment:3 Changed 7 years ago by mlinkert
comment:4 Changed 7 years ago by rleigh
Testing on cls-dev-bf with test_images_good. develop tests run without failures so far. 8732-test-ordering has several hundred failures--I stopped the tests after an hour. The logs for the failures are in /ome/team/rleigh/8732-test
comment:5 Changed 7 years ago by mlinkert
- Resolution set to fixed
- Status changed from new to closed
PR merged.
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
Even if we can't reuse the reader state directly, simply running the tests in this order should ensure that the file data is in the kernel's page cache/buffer cache so we don't need to reread it from disc or fetch over the network, which is the limiting factor at present. Providing you have enough memory of course, but that's almost certainly the case for all of the systems we are running tests on.