Bug: Drag-drop error with multiple selections of the same image

[rleigh]

See attached image.

To reproduce:

1. use copy/paste to create multiple copies of the same image in different datasets
2. try to drag one of the images to the "Orphaned images" folder. While this is inconsistent, dragging one of these will fail, but leave all the copies in the different datasets selected.
3. drag one of the copies to one of the datasets already containing one of the other copies. You'll get (nselected +1) error message popups appearing ("image is already there").
4. repeat this a few times. You'll get ((nrepeats * nselected)+1) popups appearing.

Looks like it's keeping a "selection" for the items which weren't copied the first time + the visible selection, and keep appending to it.

Things to consider:
Is copying an identical file really an error? Why not just do nothing and continue without error--replacing the image with an identical copy is equivalent to doing nothing.

The management of the selected files when dragging to "Orphaned files" is buggy. Is it in fact possible to select the same files by alternative means?

The management of the selected files on failure when dragging to a folder is also buggy.

Regards,
Roger

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [25297f4d153f5ca98867cb298c1d13ed2cc38518/ome.git] on branch develop) preventing dnd to orphans, see #8776

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [ad576660630cea200ea225adbcdbb465c0ae3d4d/ome.git] on branch develop) fixing small issue in jstree.check_move, see #8776

[jburel]

Moved from sprint 2012-05-22 (15)

[wmoore]

Although this is 'critical', as discussed on yesterday's web meeting, it only arises if you try to move multiple objects in the tree and 1 or more is 'invalid' (can't move). Even then, the data integrity is preserved and you just need a tree refresh to correct the selection etc.

It's also quite tricky to fix, since we are relying on the 'rollback' functionality in jsTree, which applies to ALL the elements moved, not individual ones. There's also a selection bug which I can't understand.

Pushing since I don't think we can fix these issues just now.

[wmoore]

Just tried to reproduce this and didn't get the problems reported:

• Couldn't drag an image into orphaned
• Moving multiple images into a dataset that already contains 1 or more gives a notification, but allows the others to move (doesn't try to rollback, which caused the problems described above).

Closing...

[rleigh]

Works much better now. However, you do still get alert messages about duplicate images while e.g. copy/pasting duplicated files, which are repeated once per duplicate.

[wmoore]

Don't alert errors: ​https://github.com/will-moore/openmicroscopy/commit/a83f0fb0ae24a99a6ff1e42b2d57f8178657bd83 in sprint2-web-bugs.

[Will Moore <will@…>]

(In [345090c2fb52b97a37b06c567745d443c67280fa/ome.git] on branch develop) Don't show alert messages for failed drag/move in Tree. See #8776