Bug: changing group permissions

[jburel]

Modify groups permissions. All tests now failed. No response sent back to the following

final HandlePrx prx = f.submit(change);
		assertFalse(prx.getStatus().flags.contains(State.FAILURE));
		new CmdCallbackI(c, prx).loop(20, 500);
		assertNotNull(prx.getResponse());

always fails.
Added more test to AdminServiceTest jburel/bugs-sprint15 on gh.
This is develop

[jmoore]

I don't know what could have caused this. I haven't changed anything in that area. Trying to reproduce now.

[jmoore]

Found this in the server log:

2012-05-17 12:37:19,766 INFO  [                       omero.cmd.HandleI] (2-thread-4) Running omero.cmd.graphs.ChmodI@32fe1652
2012-05-17 12:37:19,768 INFO  [   ome.security.basic.GroupChmodStrategy] (2-thread-4) Changed permissions for 2672 to -8
2012-05-17 12:37:19,768 INFO  [       ome.security.basic.CurrentDetails] (2-thread-4) Adding log:CHMOD(rwrw--),class ome.model.meta.ExperimenterGroup,2672
2012-05-17 12:37:19,768 INFO  [                 org.perf4j.TimingLogger] (2-thread-4) start[1337251039767] time[1] tag[omero.request.step.0]
2012-05-17 12:37:19,768 ERROR [                       omero.cmd.HandleI] (2-thread-4) Failure during Request.step:java.lang.ArithmeticException: / by zero
        at omero.cmd.HandleI.steps(HandleI.java:435)
        at omero.cmd.HandleI.doRun(HandleI.java:399)        at omero.cmd.HandleI$1.doWork(HandleI.java:350)
        at omero.cmd.HandleI$1.doWork(HandleI.java:346)

[jmoore]

Fixed and pushing to bugfixes-sprint15.

[jmoore]

(tested by running AdminServiceTest? as it is in develop; all tests passed)

[jmoore]

forgot to click on 'fixed'

[jmoore <josh@…>]

(In [a6dc3afddb9c6a8edba73be3a068f97e907e8d30/ome.git] on branch develop) Fix modulus logic in HandleI (Fix #8845, See #2485)

If there were too few steps, then an arithmetic exception
was being thrown leading to no callback reaching the client
within the tests expected 10 seconds.

We may should make the timeout try again with a poll
to be sure it wasn't a network or other issue.